Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(16)

Issue 14698027: Move winaura specific methods and members from chrome/browser/browser_process.h to chrome/browser/b… (Closed)

Created:
7 years, 7 months ago by gab
Modified:
7 years, 7 months ago
Reviewers:
sky
CC:
chromium-reviews
Visibility:
Public.

Description

Move winaura specific methods and members from chrome/browser/browser_process.h to chrome/browser/browser_process_platform_part_winaura.h Precursor CL to https://codereview.chromium.org/14576015/ BUG=235648, 232842, 179830 Originally Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=200576 Reverted: http://crrev.com/200656 The cause of the issue is that the current paradigm is such that you can still include the header from the base class although the base class is ruled out in gyp... this resulted in a Heap Corruption debug check when deleting the TestingBrowserProcessPlatformPart on WinAura since it would take its definition from browser_process_platform_part.h at compile time, but use the impl from browser_process_platform_part_aurawin.h at runtime... This paradigm is being fixed in https://codereview.chromium.org/14951007/ and thus simply #ifdefing the right definition in testing_browser_process_platform_part.h for now is fine. Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=200926

Patch Set 1 : #

Patch Set 2 : merge up to r200274 #

Patch Set 3 : fix non-win compile #

Patch Set 4 : _winaura.cc => _aurawin.cc #

Patch Set 5 : Fix includes in testing_browser_process_platform_part.h #

Unified diffs Side-by-side diffs Delta from patch set Stats (+100 lines, -100 lines) Patch
M chrome/browser/browser_process.h View 1 2 chunks +0 lines, -9 lines 0 comments Download
M chrome/browser/browser_process_impl.h View 1 3 chunks +0 lines, -17 lines 0 comments Download
M chrome/browser/browser_process_impl.cc View 1 2 3 3 chunks +2 lines, -9 lines 0 comments Download
D chrome/browser/browser_process_impl_win.cc View 1 chunk +0 lines, -35 lines 0 comments Download
M chrome/browser/browser_process_platform_part.h View 1 chunk +7 lines, -0 lines 0 comments Download
M chrome/browser/browser_process_platform_part.cc View 1 chunk +4 lines, -0 lines 0 comments Download
A chrome/browser/browser_process_platform_part_aurawin.h View 1 2 3 1 chunk +37 lines, -0 lines 0 comments Download
A + chrome/browser/browser_process_platform_part_aurawin.cc View 1 2 3 2 chunks +14 lines, -16 lines 0 comments Download
M chrome/browser/browser_process_platform_part_chromeos.h View 2 chunks +7 lines, -0 lines 0 comments Download
M chrome/browser/browser_process_platform_part_chromeos.cc View 1 chunk +4 lines, -0 lines 0 comments Download
M chrome/browser/chrome_browser_main.cc View 1 2 3 2 chunks +8 lines, -1 line 0 comments Download
M chrome/browser/metro_viewer/metro_viewer_process_host_win.cc View 1 2 3 2 chunks +2 lines, -1 line 0 comments Download
M chrome/browser/process_singleton_win.cc View 1 2 3 2 chunks +7 lines, -1 line 0 comments Download
M chrome/chrome_browser.gypi View 1 2 3 2 chunks +4 lines, -1 line 0 comments Download
M chrome/test/base/testing_browser_process.h View 1 1 chunk +0 lines, -6 lines 0 comments Download
M chrome/test/base/testing_browser_process.cc View 1 1 chunk +0 lines, -4 lines 0 comments Download
M chrome/test/base/testing_browser_process_platform_part.h View 1 2 3 4 1 chunk +4 lines, -0 lines 0 comments Download

Messages

Total messages: 9 (0 generated)
gab
Scott PTAL, this is a precursor CL to address your comment on https://codereview.chromium.org/14576015/. Thanks, Gab
7 years, 7 months ago (2013-05-15 17:14:09 UTC) #1
sky
LGTM
7 years, 7 months ago (2013-05-15 21:12:20 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/gab@chromium.org/14698027/13001
7 years, 7 months ago (2013-05-16 13:36:27 UTC) #3
commit-bot: I haz the power
Retried try job too often on linux_chromeos for step(s) interactive_ui_tests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=linux_chromeos&number=114971
7 years, 7 months ago (2013-05-16 14:29:08 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/gab@chromium.org/14698027/13001
7 years, 7 months ago (2013-05-16 17:28:51 UTC) #5
commit-bot: I haz the power
Change committed as 200576
7 years, 7 months ago (2013-05-16 18:02:12 UTC) #6
gab
@Scott, patch set 4 was committed and reverted, see augmented CL description for details. Re-committing ...
7 years, 7 months ago (2013-05-17 19:15:42 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/gab@chromium.org/14698027/40001
7 years, 7 months ago (2013-05-17 19:16:03 UTC) #8
commit-bot: I haz the power
7 years, 7 months ago (2013-05-17 23:36:38 UTC) #9
Message was sent while issue was closed.
Change committed as 200926

Powered by Google App Engine
This is Rietveld 408576698