DescriptionMove winaura specific methods and members from chrome/browser/browser_process.h to chrome/browser/browser_process_platform_part_winaura.h
Precursor CL to https://codereview.chromium.org/14576015/
BUG=235648, 232842, 179830
Originally Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=200576
Reverted: http://crrev.com/200656
The cause of the issue is that the current paradigm is such that you can still include the header from the base class although the base class is ruled out in gyp... this resulted in a Heap Corruption debug check when deleting the TestingBrowserProcessPlatformPart on WinAura since it would take its definition from browser_process_platform_part.h at compile time, but use the impl from browser_process_platform_part_aurawin.h at runtime...
This paradigm is being fixed in https://codereview.chromium.org/14951007/ and thus simply #ifdefing the right definition in testing_browser_process_platform_part.h for now is fine.
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=200926
Patch Set 1 : #Patch Set 2 : merge up to r200274 #Patch Set 3 : fix non-win compile #Patch Set 4 : _winaura.cc => _aurawin.cc #Patch Set 5 : Fix includes in testing_browser_process_platform_part.h #Messages
Total messages: 9 (0 generated)
|