Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(149)

Issue 14698008: Remove RetainPtrObjectHash and RetainPtrObjectHashTraits (Closed)

Created:
7 years, 7 months ago by Mikhail
Modified:
7 years, 7 months ago
CC:
blink-reviews, loislo+blink_chromium.org, jeez, eae+blinkwatch, yurys+blink_chromium.org, abarth-chromium
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Visibility:
Public.

Description

Remove RetainPtrObjectHash and RetainPtrObjectHashTraits RetainPtrObjectHash and RetainPtrObjectHashTraits classes are used in Safari and not used anywhere in Blink or Chromium, so they should be removed from Blink WTF. Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=150039

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -28 lines) Patch
M Source/wtf/RetainPtr.h View 1 chunk +1 line, -28 lines 0 comments Download

Messages

Total messages: 7 (0 generated)
Mikhail
Hello, Could you please have a look? BR, Mikhail
7 years, 7 months ago (2013-05-09 16:07:43 UTC) #1
abarth-chromium
lgtm Do we use RetainPtr at all?
7 years, 7 months ago (2013-05-09 16:51:42 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/mikhail.pozdnyakov@intel.com/14698008/1
7 years, 7 months ago (2013-05-09 16:51:53 UTC) #3
commit-bot: I haz the power
Change committed as 150039
7 years, 7 months ago (2013-05-09 19:08:16 UTC) #4
eseidel
retainptr was a CF thing. I believe it was used for GTK, and could be ...
7 years, 7 months ago (2013-05-09 19:16:44 UTC) #5
Mikhail
On 2013/05/09 19:16:44, Eric Seidel wrote: > retainptr was a CF thing. I believe it ...
7 years, 7 months ago (2013-05-10 07:28:46 UTC) #6
abarth-chromium
7 years, 7 months ago (2013-05-10 16:13:10 UTC) #7
Message was sent while issue was closed.
Probably not.

Powered by Google App Engine
This is Rietveld 408576698