Verify that no-side-effects scope does not add unsafe phis and does not change push-pop balance of …

Verify that no-side-effects scope does not add unsafe phis and does not change push-pop balance of the environment.

R=danno@chromium.org
BUG=v8:2671
Committed: https://code.google.com/p/v8/source/detail?r=14610

[ulan, 2013-05-08 14:01:46]

PTAL

https://chromiumcodereview.appspot.com/14696015/diff/2001/src/hydrogen.cc
File src/hydrogen.cc (right):

https://chromiumcodereview.appspot.com/14696015/diff/2001/src/hydrogen.cc#new...
src/hydrogen.cc:8375: HValue* key = environment()->ExpressionStackAt(0);
This doesn't trigger the verification check. Changing it for consistency of
HandleKeyedElementAccess calls.

[ulan, 2013-05-08 15:24:29]

Uploaded new patch set, added assertion after each GotoNoSimulate instead of
doing it in set_current_block.

[danno, 2013-05-08 16:24:27]

lgtm with comments

https://chromiumcodereview.appspot.com/14696015/diff/8001/src/hydrogen.h
File src/hydrogen.h (right):

https://chromiumcodereview.appspot.com/14696015/diff/8001/src/hydrogen.h#newc...
src/hydrogen.h:937: no_side_effects_scope_environment_push_pop_delta_(0),
This is a bit long :-)
How about just no_side_effects_scope_env_delta_

[ulan, 2013-05-10 08:40:43]

Landing.

https://chromiumcodereview.appspot.com/14696015/diff/8001/src/hydrogen.h
File src/hydrogen.h (right):

https://chromiumcodereview.appspot.com/14696015/diff/8001/src/hydrogen.h#newc...
src/hydrogen.h:937: no_side_effects_scope_environment_push_pop_delta_(0),
On 2013/05/08 16:24:27, danno wrote:
> This is a bit long :-)
> How about just no_side_effects_scope_env_delta_

Done.

[ulan, 2013-05-10 09:26:59]

Committed patchset #5 manually as r14610 (presubmit successful).