Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(364)

Issue 14693006: Docserver: update handlebar. (Closed)

Created:
7 years, 7 months ago by not at google - send to devlin
Modified:
7 years, 7 months ago
Reviewers:
cduvall
CC:
chromium-reviews, Aaron Boodman, chromium-apps-reviews_chromium.org
Visibility:
Public.

Description

Docserver: update third_party/handlebar. handlebar.py (used in the docserver) now has much faster rendering (about 3x improvement) and parsing (about 2x improvement). This halves the runtime of the integration/cron tests as well as making page load snappier. NOTRY=true Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=200687

Patch Set 1 #

Messages

Total messages: 4 (0 generated)
not at google - send to devlin
Hey Clark, CL description is brief because I have to run, but this updates to ...
7 years, 7 months ago (2013-05-16 23:02:35 UTC) #1
cduvall
lgtm. Yay speed increase! I looked over the handlebar code, but not super closely.
7 years, 7 months ago (2013-05-17 01:05:47 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/kalman@chromium.org/14693006/1
7 years, 7 months ago (2013-05-17 01:35:35 UTC) #3
commit-bot: I haz the power
7 years, 7 months ago (2013-05-17 01:40:19 UTC) #4
Message was sent while issue was closed.
Change committed as 200687

Powered by Google App Engine
This is Rietveld 408576698