Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(43)

Issue 14680006: Increase the stripping level of the nacl irt. (Closed)

Created:
7 years, 7 months ago by bradn
Modified:
7 years, 7 months ago
Reviewers:
bbudge, Roland McGrath
CC:
chromium-reviews
Visibility:
Public.

Description

Increase the stripping level of the nacl irt. Changes in nacl's build_nexe.py script mean that symbol information will be kept in a known location after stripping, allowing archival. This means we can use strip-all in place of strip-debug. NOTE: Until recently strip-all was already happening on linux in an internal release buildbot script. Depends on this change landing in nacl and rolling into chrome: https://codereview.chromium.org/14705005/ BUG=None TEST=None R=mcgrathr@chromium.org,bbudge@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=198496

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M ppapi/native_client/native_client.gyp View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 5 (0 generated)
bradn
7 years, 7 months ago (2013-05-02 20:20:47 UTC) #1
Roland McGrath
lgtm
7 years, 7 months ago (2013-05-02 20:27:53 UTC) #2
bbudge
LGTM
7 years, 7 months ago (2013-05-02 21:40:38 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/bradnelson@google.com/14680006/1
7 years, 7 months ago (2013-05-06 17:00:39 UTC) #4
commit-bot: I haz the power
7 years, 7 months ago (2013-05-06 19:06:23 UTC) #5
Message was sent while issue was closed.
Change committed as 198496

Powered by Google App Engine
This is Rietveld 408576698