Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(118)

Issue 14677012: Made Blink tooltip ShadowDOM-aware (Closed)

Created:
7 years, 7 months ago by Hajime Morrita
Modified:
7 years, 7 months ago
Reviewers:
hayato, dglazkov
CC:
blink-reviews, caseq+blink_chromium.org, loislo+blink_chromium.org, eustas+blink_chromium.org, alph+blink_chromium.org, eae+blinkwatch, yurys+blink_chromium.org, lushnikov+blink_chromium.org, leviw+renderwatch, vsevik+blink_chromium.org, pfeldman+blink_chromium.org, apavlov+blink_chromium.org, jchaffraix+rendering, aandrey+blink_chromium.org
Visibility:
Public.

Description

Made Blink tooltip ShadowDOM-aware Before this change, tooltip lookup on EventHandler::mouseMoved() filtered in-shadow nodes out. That results broken tooltip display of these in-shadow elements. Such filtering was originally introduced to hide UA shadows, but the implementation was a bit too aggressive that it filtered all shadow out. This chagne add HitTestResult::setToShadowHostIfUserAgentShadowRoot(). This is a relaxed version of such filtering, which only hides nodes in UA shadow. Using this, tooltip is correctly located even if it is inside shadows. BUG=234100 TEST=tooltips-in-shdaow.html Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=150278

Patch Set 1 #

Total comments: 4
Unified diffs Side-by-side diffs Delta from patch set Stats (+101 lines, -11 lines) Patch
A LayoutTests/fast/dom/shadow/tooltips-in-shadow.html View 1 chunk +60 lines, -0 lines 2 comments Download
A LayoutTests/fast/dom/shadow/tooltips-in-shadow-expected.txt View 1 chunk +10 lines, -0 lines 0 comments Download
M Source/core/inspector/InspectorDOMAgent.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/page/EventHandler.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M Source/core/rendering/HitTestResult.h View 1 chunk +2 lines, -1 line 0 comments Download
M Source/core/rendering/HitTestResult.cpp View 2 chunks +26 lines, -7 lines 2 comments Download

Messages

Total messages: 7 (0 generated)
Hajime Morrita
Hayato-san, could you take an informal review? Then Dimitri might be able to stamp while ...
7 years, 7 months ago (2013-05-13 10:49:31 UTC) #1
dglazkov
https://codereview.chromium.org/14677012/diff/1/LayoutTests/fast/dom/shadow/tooltips-in-shadow.html File LayoutTests/fast/dom/shadow/tooltips-in-shadow.html (right): https://codereview.chromium.org/14677012/diff/1/LayoutTests/fast/dom/shadow/tooltips-in-shadow.html#newcode27 LayoutTests/fast/dom/shadow/tooltips-in-shadow.html:27: container.appendChild(D('div', {'id': 'host3'}, S(D('div', {'id': 'scope3a'})), S(D('a', {'id': 'scope3b', ...
7 years, 7 months ago (2013-05-13 16:11:42 UTC) #2
Hajime Morrita
Thanks for reviewing, Dimitri! https://codereview.chromium.org/14677012/diff/1/LayoutTests/fast/dom/shadow/tooltips-in-shadow.html File LayoutTests/fast/dom/shadow/tooltips-in-shadow.html (right): https://codereview.chromium.org/14677012/diff/1/LayoutTests/fast/dom/shadow/tooltips-in-shadow.html#newcode27 LayoutTests/fast/dom/shadow/tooltips-in-shadow.html:27: container.appendChild(D('div', {'id': 'host3'}, S(D('div', {'id': ...
7 years, 7 months ago (2013-05-14 00:13:52 UTC) #3
dglazkov
LGTM.
7 years, 7 months ago (2013-05-14 00:44:13 UTC) #4
Hajime Morrita
Thx!
7 years, 7 months ago (2013-05-14 00:52:07 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/morrita@chromium.org/14677012/1
7 years, 7 months ago (2013-05-14 00:52:14 UTC) #6
commit-bot: I haz the power
7 years, 7 months ago (2013-05-14 02:01:52 UTC) #7
Message was sent while issue was closed.
Change committed as 150278

Powered by Google App Engine
This is Rietveld 408576698