Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1880)

Issue 14676015: Fix texture copy issue in video painting on Canvas for Chrome on Android. (Closed)

Created:
7 years, 7 months ago by Shouqun Liu
Modified:
7 years, 7 months ago
CC:
blink-reviews, feature-media-reviews_chromium.org, eae+blinkwatch
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Visibility:
Public.

Description

Fix texture copy issue in video painting on Canvas for Chrome on Android. Need to set type as GraphicsContext3D::UNSIGNED_BYTE since the API is changed. BUG=147265 TEST=webgl/conformance/textures/tex-image-and-sub-image-2d-with-video.html or http://html5doctor.com/demos/video-canvas-magic/demo1.html Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=150496

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -1 line) Patch
M Source/WebKit/chromium/src/WebMediaPlayerClientImpl.cpp View 1 chunk +2 lines, -1 line 0 comments Download

Messages

Total messages: 12 (0 generated)
Shouqun Liu
PTAL
7 years, 7 months ago (2013-05-15 05:43:27 UTC) #1
Jun Jiang
On 2013/05/15 05:43:27, Shouqun Liu wrote: > PTAL It was my fault that I didn't ...
7 years, 7 months ago (2013-05-15 06:53:43 UTC) #2
hkuang1
Add scherkus.
7 years, 7 months ago (2013-05-15 16:59:03 UTC) #3
Ken Russell (switch to Gerrit)
LGTM
7 years, 7 months ago (2013-05-15 22:51:54 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/shouqun.liu@intel.com/14676015/1
7 years, 7 months ago (2013-05-16 00:56:34 UTC) #5
commit-bot: I haz the power
Retried try job too often on blink_bare_presubmit for step(s) presubmit http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=blink_bare_presubmit&number=1085
7 years, 7 months ago (2013-05-16 01:02:56 UTC) #6
Shouqun Liu
abarth@: PTAL
7 years, 7 months ago (2013-05-16 01:09:29 UTC) #7
abarth-chromium
lgtm
7 years, 7 months ago (2013-05-16 05:55:42 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/shouqun.liu@intel.com/14676015/1
7 years, 7 months ago (2013-05-16 05:56:25 UTC) #9
commit-bot: I haz the power
Retried try job too often on linux_layout_rel for step(s) webkit_tests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=linux_layout_rel&number=8247
7 years, 7 months ago (2013-05-16 06:32:38 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/shouqun.liu@intel.com/14676015/1
7 years, 7 months ago (2013-05-16 07:01:02 UTC) #11
commit-bot: I haz the power
7 years, 7 months ago (2013-05-16 08:16:55 UTC) #12
Message was sent while issue was closed.
Change committed as 150496

Powered by Google App Engine
This is Rietveld 408576698