Chromium Code Reviews
Help | Chromium Project | Gerrit Changes | Sign in
(57)

Issue 14676012: [net/dns] Fix how DnsTransaction computes next server index after fallback. (Closed)

Created:
5 years, 11 months ago by szym
Modified:
5 years, 11 months ago
Reviewers:
mmenke
CC:
chromium-reviews, cbentzel+watch_chromium.org
Visibility:
Public.

Description

[net/dns] Fix how DnsTransaction computes next server index after fallback. BUG=239657 TEST=net_unittests --gtest_filter=DnsTransactionTest.ServerFallbackAndRotate Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=199402

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -3 lines) Patch
M net/dns/dns_transaction.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M net/dns/dns_transaction_unittest.cc View 2 chunks +2 lines, -1 line 0 comments Download

Messages

Total messages: 5 (0 generated)
szym
This is rather embarrassing. I have confirmed that the updated test crashes without the fix.
5 years, 11 months ago (2013-05-10 01:45:46 UTC) #1
szym
PTAL
5 years, 11 months ago (2013-05-10 01:46:07 UTC) #2
mmenke
On 2013/05/10 01:46:07, szym wrote: > PTAL Both Chris and I signed off on it, ...
5 years, 11 months ago (2013-05-10 01:53:53 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/szym@chromium.org/14676012/1
5 years, 11 months ago (2013-05-10 01:55:29 UTC) #4
commit-bot: I haz the power
5 years, 11 months ago (2013-05-10 06:15:52 UTC) #5
Message was sent while issue was closed.
Change committed as 199402

Powered by Google App Engine
This is Rietveld 408576698