Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 14674002: Support Shift+Search+Arrows to navigate and Control to silence speech everywhere (Closed)

Created:
7 years, 7 months ago by dmazzoni
Modified:
7 years, 7 months ago
CC:
chromium-reviews, mazda+watch_chromium.org, sadrul, yusukes+watch_chromium.org, derat+watch_chromium.org, ben+watch_chromium.org
Visibility:
Public.

Description

Support Shift+Search+Arrows to navigate and Control to silence speech everywhere Adds new ash keyboard shortcuts that mirror common ChromeVox keys, for use everywhere else in the UI. Only activated when spoken feedback is on. See bug for more info. BUG=236922 NOTRY=true Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=197991

Patch Set 1 #

Total comments: 2

Patch Set 2 : Rename to accessible_focus_next #

Patch Set 3 : Fix other ShellDelegate subclasses #

Patch Set 4 : Fixed non-ash ChromeShellDelegate #

Unified diffs Side-by-side diffs Delta from patch set Stats (+70 lines, -2 lines) Patch
M ash/accelerators/accelerator_controller.cc View 1 4 chunks +36 lines, -0 lines 0 comments Download
M ash/accelerators/accelerator_table.h View 1 2 chunks +3 lines, -0 lines 0 comments Download
M ash/accelerators/accelerator_table.cc View 1 2 chunks +11 lines, -2 lines 0 comments Download
M ash/shell/shell_delegate_impl.h View 1 2 1 chunk +1 line, -0 lines 0 comments Download
M ash/shell/shell_delegate_impl.cc View 1 2 1 chunk +3 lines, -0 lines 0 comments Download
M ash/shell_delegate.h View 1 chunk +3 lines, -0 lines 0 comments Download
M ash/test/test_shell_delegate.h View 1 2 1 chunk +1 line, -0 lines 0 comments Download
M ash/test/test_shell_delegate.cc View 1 2 1 chunk +3 lines, -0 lines 0 comments Download
M chrome/browser/ui/ash/chrome_shell_delegate.h View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/ui/ash/chrome_shell_delegate_chromeos.cc View 2 chunks +5 lines, -0 lines 0 comments Download
M chrome/browser/ui/ash/chrome_shell_delegate_views.cc View 1 2 3 1 chunk +3 lines, -0 lines 0 comments Download

Messages

Total messages: 9 (0 generated)
dmazzoni
zork: accessibility review derat: OWNERS review
7 years, 7 months ago (2013-04-30 20:05:01 UTC) #1
Daniel Erat
LGTM with a comment https://codereview.chromium.org/14674002/diff/1/ash/accelerators/accelerator_table.h File ash/accelerators/accelerator_table.h (right): https://codereview.chromium.org/14674002/diff/1/ash/accelerators/accelerator_table.h#newcode18 ash/accelerators/accelerator_table.h:18: ACCESSIBLE_NEXT, maybe ACCESSIBLE_FOCUS_NEXT and ACCESSIBLE_FOCUS_PREVIOUS?
7 years, 7 months ago (2013-04-30 20:22:01 UTC) #2
dmazzoni
https://codereview.chromium.org/14674002/diff/1/ash/accelerators/accelerator_table.h File ash/accelerators/accelerator_table.h (right): https://codereview.chromium.org/14674002/diff/1/ash/accelerators/accelerator_table.h#newcode18 ash/accelerators/accelerator_table.h:18: ACCESSIBLE_NEXT, On 2013/04/30 20:22:01, Daniel Erat wrote: > maybe ...
7 years, 7 months ago (2013-04-30 21:20:45 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/dmazzoni@chromium.org/14674002/6001
7 years, 7 months ago (2013-05-02 16:50:59 UTC) #4
commit-bot: I haz the power
Sorry for I got bad news for ya. Compile failed with a clobber build on ...
7 years, 7 months ago (2013-05-02 18:23:49 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/dmazzoni@chromium.org/14674002/25001
7 years, 7 months ago (2013-05-02 19:18:33 UTC) #6
commit-bot: I haz the power
Retried try job too often on linux_chromeos for step(s) browser_tests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=linux_chromeos&number=110000
7 years, 7 months ago (2013-05-02 22:03:44 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/dmazzoni@chromium.org/14674002/25001
7 years, 7 months ago (2013-05-02 22:08:22 UTC) #8
commit-bot: I haz the power
7 years, 7 months ago (2013-05-02 22:14:15 UTC) #9
Message was sent while issue was closed. 
Change committed as 197991

Powered by Google App Engine
This is Rietveld 408576698