Issue 14672033: DevTools: Make snippets renaming work through SnippetsProjectDelegate.

Issue 14672033: DevTools: Make snippets renaming work through SnippetsProjectDelegate. (Closed)

Created:
7 years, 7 months ago by vsevik

Modified:
7 years, 7 months ago

Reviewers:
apavlov, pfeldman

CC:
blink-reviews, caseq+blink_chromium.org, loislo+blink_chromium.org, eustas+blink_chromium.org, alph+blink_chromium.org, eae+blinkwatch, yurys+blink_chromium.org, lushnikov+blink_chromium.org, vsevik+blink_chromium.org, pfeldman+blink_chromium.org, apavlov+blink_chromium.org, aandrey+blink_chromium.org

Base URL:
svn://svn.chromium.org/blink/trunk

Visibility:
Public.

More Reviews

Description

DevTools: Make snippets renaming work through SnippetsProjectDelegate. Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=150450

Patch Set 1 #

Patch Set 2 : . #

Total comments: 2

Patch Set 3 : . #

Created: 7 years, 7 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+241 lines, -88 lines)			Patch
M	LayoutTests/inspector/debugger/script-snippet-model.html	View		3 chunks	+29 lines, -14 lines	0 comments	Download
M	LayoutTests/inspector/debugger/script-snippet-model-expected.txt	View		1 chunk	+26 lines, -2 lines	0 comments	Download
M	Source/devtools/front_end/ContentProviderBasedProjectDelegate.js	View		1 chunk	+18 lines, -0 lines	0 comments	Download
M	Source/devtools/front_end/FileSystemProjectDelegate.js	View		1 chunk	+18 lines, -0 lines	0 comments	Download
M	Source/devtools/front_end/NavigatorView.js	View	1 2	7 chunks	+36 lines, -26 lines	0 comments	Download
M	Source/devtools/front_end/ScriptSnippetModel.js	View	1 2	4 chunks	+36 lines, -8 lines	0 comments	Download
M	Source/devtools/front_end/ScriptsNavigator.js	View		6 chunks	+5 lines, -22 lines	0 comments	Download
M	Source/devtools/front_end/ScriptsPanel.js	View		2 chunks	+0 lines, -11 lines	0 comments	Download
M	Source/devtools/front_end/SnippetStorage.js	View		1 chunk	+13 lines, -0 lines	0 comments	Download
M	Source/devtools/front_end/UISourceCode.js	View	1	1 chunk	+30 lines, -5 lines	0 comments	Download
M	Source/devtools/front_end/Workspace.js	View		2 chunks	+30 lines, -0 lines	0 comments	Download

Messages

Total messages: 7 (0 generated)

Expand Messages | Collapse Messages

apavlov

lgtm https://codereview.chromium.org/14672033/diff/1012/Source/devtools/front_end/Workspace.js File Source/devtools/front_end/Workspace.js (right): https://codereview.chromium.org/14672033/diff/1012/Source/devtools/front_end/Workspace.js#newcode282 Source/devtools/front_end/Workspace.js:282: * @return {boolean} @override https://codereview.chromium.org/14672033/diff/1012/Source/devtools/front_end/Workspace.js#newcode290 Source/devtools/front_end/Workspace.js:290: * @param ...

7 years, 7 months ago (2013-05-15 14:37:32 UTC) #2

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/vsevik@chromium.org/14672033/1012

7 years, 7 months ago (2013-05-15 17:27:33 UTC) #3

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/vsevik@chromium.org/14672033/8001

7 years, 7 months ago (2013-05-15 17:28:35 UTC) #4

commit-bot: I haz the power

Retried try job too often on linux_layout_rel for step(s) webkit_tests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=linux_layout_rel&number=8109

7 years, 7 months ago (2013-05-15 18:08:05 UTC) #5

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/vsevik@chromium.org/14672033/8001

7 years, 7 months ago (2013-05-15 19:22:21 UTC) #6

Message was sent while issue was closed.

Change committed as 150450

Expand Messages | Collapse Messages