Google OAuth Device Flow support for FNL

services/authentication/accounts_db_manager.h

 // Copyright 2015 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
-#ifndef SERVICES_NATIVE_SUPPORT_PROCESS_TEST_BASE_H_
-#define SERVICES_NATIVE_SUPPORT_PROCESS_TEST_BASE_H_
+#ifndef SERVICES_AUTHENTICATION_ACCOUNTS_DB_MANAGER_H_
+#define SERVICES_AUTHENTICATION_ACCOUNTS_DB_MANAGER_H_
 
 #include <type_traits>
 
 #include "base/macros.h"
-#include "mojo/public/cpp/application/application_test_base.h"
-#include "mojo/services/native_support/interfaces/process.mojom.h"
+#include "mojo/services/files/interfaces/files.mojom.h"
 
-namespace native_support {
+namespace authentication {
 
-// TODO(vtl): Stuff copied from mojo/public/cpp/bindings/lib/template_util.h.
+// TODO(ukode): Stuff copied from mojo/public/cpp/bindings/lib/template_util.h.

[jln (very slow on Chromium), 2015/12/08 22:27:29]

This should definitely not be in this .h file.

If this is really needed, it could either be somewhere in a shared header file
that you include, or copied in the .cc file. (But copying call is a last-resort
evil).

Talk to vtl maybe?

[ukode, 2015/12/16 19:24:13]

Acknowledged. +Vtl

 typedef char YesType;
 
 struct NoType {
   YesType dummy[2];
 };
 
 template <typename T>
 struct IsMoveOnlyType {
   template <typename U>
   static YesType Test(const typename U::MoveOnlyTypeForCPP03*);
 
   template <typename U>
   static NoType Test(...);
 
   static const bool value =
       sizeof(Test<T>(0)) == sizeof(YesType) && !std::is_const<T>::value;
 };
 
 template <typename T>
 typename std::enable_if<!IsMoveOnlyType<T>::value, T>::type& Forward(T& t) {
   return t;
 }
 
 template <typename T>
 typename std::enable_if<IsMoveOnlyType<T>::value, T>::type Forward(T& t) {
   return t.Pass();
 }
-// TODO(vtl): (End of stuff copied from template_util.h.)
+// TODO(ukode): (End of stuff copied from template_util.h.)
 
 template <typename T1>
 mojo::Callback<void(T1)> Capture(T1* t1) {
   return [t1](T1 got_t1) { *t1 = Forward(got_t1); };
 }
 
 template <typename T1, typename T2>
 mojo::Callback<void(T1, T2)> Capture(T1* t1, T2* t2) {
   return [t1, t2](T1 got_t1, T2 got_t2) {
     *t1 = Forward(got_t1);
     *t2 = Forward(got_t2);
   };
 }
 
-class ProcessTestBase : public mojo::test::ApplicationTestBase {
+class AccountsDbManager {

[jln (very slow on Chromium), 2015/12/08 22:27:29]

Please, document your class and methods as per style guide.

[ukode, 2015/12/16 19:24:13]

Done.

  public:
-  ProcessTestBase();
-  ~ProcessTestBase() override;
+  AccountsDbManager();
+  explicit AccountsDbManager(mojo::files::FilesPtr files);
+  ~AccountsDbManager();
 
-  void SetUp() override;
-
- protected:
-  ProcessPtr& process() { return process_; }
+  bool UpdateAccount(const mojo::String& username,
+                     const mojo::String& account_data);
+  void GetAccountDataForUser(const mojo::String& username,
+                             mojo::String& user_data);
+  mojo::Array<uint8_t> FetchAllAccounts();
 
  private:
-  ProcessPtr process_;
+  bool checkIfUserExists(const std::string& user_data);

[jln (very slow on Chromium), 2015/12/08 22:27:29]

This method looks unimplemented, no?

[jln (very slow on Chromium), 2015/12/08 22:27:29]

nit: Capital C in CheckIfUserExists)

[ukode, 2015/12/16 19:24:13]

Good catch, Had it before, later removed it as it wasn't needed. Forgot to
update the header file. Fixed it now.

[ukode, 2015/12/16 19:24:13]

Done.

+  mojo::files::DirectoryPtr directory_;

[jln (very slow on Chromium), 2015/12/08 22:27:29]

Nit: vertical space

[ukode, 2015/12/16 19:24:13]

Done.

+  std::string contents_;
 
-  DISALLOW_COPY_AND_ASSIGN(ProcessTestBase);
+  DISALLOW_COPY_AND_ASSIGN(AccountsDbManager);
 };
 
-}  // namespace native_support
+}  // namespace authentication
 
-#endif  // SERVICES_NATIVE_SUPPORT_PROCESS_TEST_BASE_H_
+#endif  // SERVICES_AUTHENTICATION_ACCOUNTS_DB_MANAGER_H_