Adding ERR_SOCKET_IS_CONNECTED.

Adding ERR_SOCKET_IS_CONNECTED.

BUG=235066
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=197713

[Bei Zhang, 2013-04-30 19:40:46]

Hi wtc,

As we discussed, a new error code ERR_SOCKET_IS_CONNECTED should be added. I
only found this error on the UDPSocket code. Do you have any suggestion on where
else should we put it?

Thanks,
Bei

[wtc, 2013-04-30 23:41:59]

Patch set 1 LGTM. Thanks!

We can also map the POSIX error EISCONN and the Winsock
error WSAEISCONN to ERR_SOCKET_IS_CONNECTED.

Could you find out where we do the error mapping?
You can search for ECONNRESET and WSAECONNRESET in the
src/net directory to find the error mapping functions.

https://codereview.chromium.org/14666002/diff/1/net/base/net_error_list.h
File net/base/net_error_list.h (right):

https://codereview.chromium.org/14666002/diff/1/net/base/net_error_list.h#new...
net/base/net_error_list.h:13: //   100-199 Connection related errors

It seems that the IS_CONNECTED error could also be added
to the 100-199 range (connection/socket related errors).

Since the NOT_CONNECTED error was already added to the 0-99
range, I think it makes sense to do the same.

https://codereview.chromium.org/14666002/diff/1/net/base/net_error_list.h#new...
net/base/net_error_list.h:94: // The socket is connected.

Add "already" before "connected".

[Bei Zhang, 2013-05-01 00:03:23]

Thanks for review!

https://codereview.chromium.org/14666002/diff/1/net/base/net_error_list.h
File net/base/net_error_list.h (right):

https://codereview.chromium.org/14666002/diff/1/net/base/net_error_list.h#new...
net/base/net_error_list.h:94: // The socket is connected.
On 2013/04/30 23:41:59, wtc wrote:
> 
> Add "already" before "connected".

Done.

[wtc, 2013-05-01 01:01:00]

Patch set 2 LGTM.

You can commit the CL after making the changes I suggested
below. You don't need to wait for a new review by me. Thanks.

https://codereview.chromium.org/14666002/diff/4001/net/base/net_errors_posix.cc
File net/base/net_errors_posix.cc (right):

https://codereview.chromium.org/14666002/diff/4001/net/base/net_errors_posix....
net/base/net_errors_posix.cc:53: return ERR_SOCKET_NOT_CONNECTED;

Nit: could you add the new error code here?

This way the related error codes are handled together.

https://codereview.chromium.org/14666002/diff/4001/net/base/net_errors_win.cc
File net/base/net_errors_win.cc (right):

https://codereview.chromium.org/14666002/diff/4001/net/base/net_errors_win.cc...
net/base/net_errors_win.cc:48: return ERR_SOCKET_NOT_CONNECTED;

Nit: could you add the new error code here?

[Bei Zhang, 2013-05-01 03:49:26]

Thanks!
Now committing.

https://codereview.chromium.org/14666002/diff/4001/net/base/net_errors_posix.cc
File net/base/net_errors_posix.cc (right):

https://codereview.chromium.org/14666002/diff/4001/net/base/net_errors_posix....
net/base/net_errors_posix.cc:53: return ERR_SOCKET_NOT_CONNECTED;
On 2013/05/01 01:01:00, wtc wrote:
> 
> Nit: could you add the new error code here?
> 
> This way the related error codes are handled together.

Done.

https://codereview.chromium.org/14666002/diff/4001/net/base/net_errors_win.cc
File net/base/net_errors_win.cc (right):

https://codereview.chromium.org/14666002/diff/4001/net/base/net_errors_win.cc...
net/base/net_errors_win.cc:48: return ERR_SOCKET_NOT_CONNECTED;
On 2013/05/01 01:01:00, wtc wrote:
> 
> Nit: could you add the new error code here?

Done.

[commit-bot: I haz the power, 2013-05-01 03:49:34]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/ikarienator@chromium.org/14666002/12001

[commit-bot: I haz the power, 2013-05-01 04:02:41]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/ikarienator@chromium.org/14666002/12001

[commit-bot: I haz the power, 2013-05-01 04:09:33]

Sorry for I got bad news for ya.
Compile failed with a clobber build on android_clang_dbg.
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=android_cl...
Your code is likely broken or HEAD is junk. Please ensure your
code is not broken then alert the build sheriffs.
Look at the try server FAQ for more details.

[commit-bot: I haz the power, 2013-05-01 06:16:01]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/ikarienator@chromium.org/14666002/12001

[commit-bot: I haz the power, 2013-05-01 06:28:34]

Sorry for I got bad news for ya.
Compile failed with a clobber build on android_clang_dbg.
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=android_cl...
Your code is likely broken or HEAD is junk. Please ensure your
code is not broken then alert the build sheriffs.
Look at the try server FAQ for more details.

[commit-bot: I haz the power, 2013-05-01 18:27:34]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/ikarienator@chromium.org/14666002/12001

[commit-bot: I haz the power, 2013-05-01 21:18:08]

Change committed as 197713