Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(330)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 14663010: Save and restore State for ShellWindows, including panels (Closed)

Created:
7 years, 7 months ago by stevenjb
Modified:
7 years, 7 months ago
CC:
chromium-reviews, jeremya+watch_chromium.org, sadrul, marja+watch_chromium.org, tfarina, ben+watch_chromium.org, jianli, Dmitry Titov, sail+watch_chromium.org, Aaron Boodman, jennb, dcheng, chromium-apps-reviews_chromium.org
Visibility:
Public.

Description

Save and restore State for ShellWindows, including panels This replaces ShellWindow::CreateParams::State with ui::WindowShowState for simplicty and consistency with Browser session restore. BUG=233556 TBR=flackr@chromium.org, skuhne@chromium.org, sky@chromium.org Original CL: https://codereview.chromium.org/14031021/ + disabled flakey browser tests on linux Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=199145

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+337 lines, -123 lines) Patch
M ash/wm/base_layout_manager.cc View 2 chunks +3 lines, -3 lines 0 comments Download
M ash/wm/window_properties.h View 1 chunk +0 lines, -4 lines 0 comments Download
M ash/wm/window_properties.cc View 1 chunk +0 lines, -2 lines 0 comments Download
M ash/wm/workspace/workspace_layout_manager.cc View 2 chunks +3 lines, -3 lines 0 comments Download
M ash/wm/workspace/workspace_manager.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/extensions/api/app_window/app_window_api.cc View 6 chunks +21 lines, -11 lines 0 comments Download
M chrome/browser/extensions/platform_app_browsertest.cc View 1 chunk +12 lines, -0 lines 0 comments Download
M chrome/browser/extensions/shell_window_geometry_cache.h View 3 chunks +11 lines, -2 lines 0 comments Download
M chrome/browser/extensions/shell_window_geometry_cache.cc View 6 chunks +16 lines, -5 lines 0 comments Download
M chrome/browser/extensions/shell_window_geometry_cache_unittest.cc View 8 chunks +65 lines, -36 lines 0 comments Download
M chrome/browser/sessions/session_service.cc View 2 chunks +2 lines, -7 lines 0 comments Download
M chrome/browser/ui/base_window.h View 2 chunks +4 lines, -0 lines 0 comments Download
M chrome/browser/ui/cocoa/browser_window_cocoa.h View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/ui/cocoa/browser_window_cocoa.mm View 1 chunk +8 lines, -0 lines 0 comments Download
M chrome/browser/ui/cocoa/extensions/native_app_window_cocoa.h View 2 chunks +2 lines, -0 lines 0 comments Download
M chrome/browser/ui/cocoa/extensions/native_app_window_cocoa.mm View 2 chunks +10 lines, -0 lines 0 comments Download
M chrome/browser/ui/extensions/native_app_window.h View 1 chunk +3 lines, -0 lines 0 comments Download
M chrome/browser/ui/extensions/shell_window.h View 2 chunks +2 lines, -8 lines 0 comments Download
M chrome/browser/ui/extensions/shell_window.cc View 6 chunks +21 lines, -21 lines 0 comments Download
M chrome/browser/ui/gtk/browser_window_gtk.h View 2 chunks +8 lines, -7 lines 0 comments Download
M chrome/browser/ui/gtk/browser_window_gtk.cc View 1 chunk +8 lines, -0 lines 0 comments Download
M chrome/browser/ui/gtk/extensions/native_app_window_gtk.h View 1 chunk +2 lines, -0 lines 0 comments Download
M chrome/browser/ui/gtk/extensions/native_app_window_gtk.cc View 2 chunks +10 lines, -0 lines 0 comments Download
M chrome/browser/ui/panels/panel.h View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/ui/panels/panel.cc View 1 chunk +4 lines, -0 lines 0 comments Download
M chrome/browser/ui/views/extensions/native_app_window_views.h View 2 chunks +2 lines, -0 lines 0 comments Download
M chrome/browser/ui/views/extensions/native_app_window_views.cc View 4 chunks +45 lines, -9 lines 0 comments Download
M chrome/browser/ui/views/frame/browser_view.h View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/ui/views/frame/browser_view.cc View 1 chunk +8 lines, -0 lines 0 comments Download
M chrome/renderer/resources/extensions/app_window_custom_bindings.js View 1 chunk +3 lines, -3 lines 0 comments Download
M chrome/test/base/test_browser_window.h View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/test/base/test_browser_window.cc View 1 chunk +4 lines, -0 lines 0 comments Download
A + chrome/test/data/extensions/platform_apps/restore_state/empty.html View 0 chunks +-1 lines, --1 lines 0 comments Download
A + chrome/test/data/extensions/platform_apps/restore_state/manifest.json View 1 chunk +1 line, -1 line 0 comments Download
A chrome/test/data/extensions/platform_apps/restore_state/test.js View 1 chunk +46 lines, -0 lines 0 comments Download
M ui/aura/client/aura_constants.h View 1 chunk +5 lines, -0 lines 0 comments Download
M ui/aura/client/aura_constants.cc View 1 chunk +2 lines, -0 lines 0 comments Download
M ui/base/ui_base_types.h View 1 chunk +2 lines, -1 line 0 comments Download

Messages

Total messages: 2 (0 generated)
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/stevenjb@chromium.org/14663010/1
7 years, 7 months ago (2013-05-08 21:31:28 UTC) #1
commit-bot: I haz the power
7 years, 7 months ago (2013-05-09 06:11:02 UTC) #2
Message was sent while issue was closed. 
Change committed as 199145

Powered by Google App Engine
This is Rietveld 408576698