chrome/browser/ui/webui/sync_setup_handler.cc - Issue 14655009: Client changes for disabled dasher account

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/webui/sync_setup_handler.cc

Issue 14655009: Client changes for disabled dasher account (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Add comment Created 7 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/browser/ui/webui/sync_setup_handler.cc

diff --git a/chrome/browser/ui/webui/sync_setup_handler.cc b/chrome/browser/ui/webui/sync_setup_handler.cc

index ec7e461a237f81a0949a3ff3bf1d10dd4cf1948d..6199edf091e0a518e1a0fafee6c9975013d74779 100644

--- a/chrome/browser/ui/webui/sync_setup_handler.cc

+++ b/chrome/browser/ui/webui/sync_setup_handler.cc

@@ -1147,8 +1147,8 @@ void SyncSetupHandler::CloseSyncSetup() {

if (IsActiveLogin()) {

// Don't log a cancel event if the sync setup dialog is being

// automatically closed due to an auth error.

- if ((!sync_service || !sync_service->HasSyncSetupCompleted()) &&

- sync_service->GetAuthError().state() == GoogleServiceAuthError::NONE) {

+ if (!sync_service || (!sync_service->HasSyncSetupCompleted() &&

+ sync_service->GetAuthError().state() == GoogleServiceAuthError::NONE)) {

if (signin_tracker_.get()) {

ProfileSyncService::SyncEvent(

ProfileSyncService::CANCEL_DURING_SIGNON);