Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1969)

Unified Diff: chrome/browser/android/preferences/important_sites_util.h

Issue 1465363002: [Storage] Android - ManageSpace UI, Important Origins, and CBD Dialog (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Favicon support, and scroll indicators Created 4 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/android/preferences/important_sites_util.h
diff --git a/chrome/browser/android/preferences/important_sites_util.h b/chrome/browser/android/preferences/important_sites_util.h
index eebba7b6cff03cc8caa6d39be0b063663980de3c..32443ef337c7c5385bcf5954be0bc18e4224ae9c 100644
--- a/chrome/browser/android/preferences/important_sites_util.h
+++ b/chrome/browser/android/preferences/important_sites_util.h
@@ -9,6 +9,7 @@
#include <vector>
#include "base/macros.h"
+#include "url/gurl.h"
class Profile;
@@ -17,12 +18,20 @@ class ImportantSitesUtil {
// This returns the top |<=max_results| important registerable
// domains. This uses site engagement and notifications to generate the list.
// |max_results| is assumed to be small.
+ // If |optional_example_origins| is specified we populate that list with
+ // example origins for each domain. This can be used for favicons.
Theresa 2016/05/25 18:14:27 nit: "... to retrieve favicons." ?
dmurph 2016/05/25 20:32:23 Done.
// See net/base/registry_controlled_domains/registry_controlled_domain.h for
// more details on registrable domains and the current list of effective
// eTLDs.
static std::vector<std::string> GetImportantRegisterableDomains(
Profile* profile,
- size_t max_results);
+ size_t max_results,
+ std::vector<GURL>* optional_example_origins);
+
+ // This marks the given origin as important so we can test features that rely
+ // on important sites.
+ static void MarkOriginAsImportantForTesting(Profile* profile,
+ const GURL& origin);
private:
DISALLOW_IMPLICIT_CONSTRUCTORS(ImportantSitesUtil);

Powered by Google App Engine
This is Rietveld 408576698