Issue 14652033: Add histograms for MouseEventPrefetch.Tap* and fix wrong enum description for MouseEventFollowedByC…

Issue 14652033: Add histograms for MouseEventPrefetch.Tap* and fix wrong enum description for MouseEventFollowedByC… (Closed)

Created:
7 years, 7 months ago by kouhei (in TOK)

Modified:
7 years, 7 months ago

Reviewers:
Ilya Sherman

CC:
chromium-reviews, MAD, Ilya Sherman, jar (doing other things), haraken, tburkard

Base URL:
https://chromium.googlesource.com/chromium/src.git@master

Visibility:
Public.

More Reviews

Description

Add histograms for MouseEventPrefetch.Tap* and fix wrong enum description for MouseEventFollowedByClick. This is continuation of: https://codereview.chromium.org/15027003/ BUG=234036 NOTRY=true Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=200135

Patch Set 2 : fix wrong desc #

Total comments: 4

Patch Set 3 : fix typo #

Created: 7 years, 7 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+23 lines, -2 lines)			Patch
	M	tools/metrics/histograms/histograms.xml	View	1 2	2 chunks	+23 lines, -2 lines	0 comments	Download

Messages

Total messages: 5 (0 generated)

Expand Messages | Collapse Messages

Ilya Sherman

LGTM % nits https://codereview.chromium.org/14652033/diff/3001/tools/metrics/histograms/histograms.xml File tools/metrics/histograms/histograms.xml (right): https://codereview.chromium.org/14652033/diff/3001/tools/metrics/histograms/histograms.xml#newcode1238 tools/metrics/histograms/histograms.xml:1238: <histogram name="MouseEventPrefetch.TapUnconfirmds"> nit: The histogram name ...

7 years, 7 months ago (2013-05-14 20:57:01 UTC) #2

kouhei (in TOK)

Fixed nits. Thanks for review! https://codereview.chromium.org/14652033/diff/3001/tools/metrics/histograms/histograms.xml File tools/metrics/histograms/histograms.xml (right): https://codereview.chromium.org/14652033/diff/3001/tools/metrics/histograms/histograms.xml#newcode1238 tools/metrics/histograms/histograms.xml:1238: <histogram name="MouseEventPrefetch.TapUnconfirmds"> On 2013/05/14 ...

7 years, 7 months ago (2013-05-15 01:21:36 UTC) #3

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/kouhei@chromium.org/14652033/7001

7 years, 7 months ago (2013-05-15 01:21:51 UTC) #4

Message was sent while issue was closed.

Change committed as 200135

Expand Messages | Collapse Messages