Alert on zero online devices when last devices file is missing or empty.

build/android/device_status_check.py

Index: build/android/device_status_check.py
diff --git a/build/android/device_status_check.py b/build/android/device_status_check.py
index 642e4eeb2a841aec9f503ac35b4aa1abea15caa1..efe4db2ca1ab8fcb8e5dbb8d31e921faf19f2eb0 100755
--- a/build/android/device_status_check.py
+++ b/build/android/device_status_check.py
@@ -110,6 +110,10 @@ def CheckForMissingDevices(options, adb_online_devs):
   WriteDeviceList('.last_devices', (adb_online_devs + last_devices))

[Isaac (away), 2013/05/07 07:57:50]

make a variable:

all_known_devices = adb_online_devs + last_devices
and use on line 113

   WriteDeviceList('.last_missing', missing_devs)
 
+  if not adb_online_devs and not last_devices:

[Isaac (away), 2013/05/07 01:57:08]

Not sure this is needed.  Can you move the devices check on line 191 to line 167
and remove the if clause on 168?

[Siva Chandra, 2013/05/07 06:42:55]

Wouldn't it be useful to report last devices (if .last_devices was present)
rather than returning immediately when no devices are found?

[Isaac (away), 2013/05/07 07:20:13]

But this bypasses all the other logic.  Why not integrate.  For example if you
want to information give last_devices is present, you're now skipping lines
117-119.

You're also not writing a .last_devices file anymore.

In short, you cannot early return from this function.

[Siva Chandra, 2013/05/07 07:43:10]

The 'if' at line 117 is executed if there were missing devices. For missing
devices to be present, last_devices have to exist. In which case, the 'if' block
I added will not execute.
.last_devices and .last_missing are written at line 110 and 111 above, before
the new 'if' block.

[Isaac (away), 2013/05/07 07:57:50]

Good point.

+    # This can happen if for some reason the .last_devices file is not
+    # present or if it was empty.
+    return ['No online devices. Have any devices been plugged in?']
   if missing_devs:
     devices_missing_msg = '%d devices not detected.' % len(missing_devs)
     buildbot_report.PrintSummaryText(devices_missing_msg)