Issue 14651031: Convert degenerate memcmp() to strncmp() in SQLite TimeMachine patch.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 14651031: Convert degenerate memcmp() to strncmp() in SQLite TimeMachine patch. (Closed)

Created:
7 years, 7 months ago by Scott Hess - ex-Googler

Modified:
7 years, 7 months ago

Reviewers:
wtc

CC:
chromium-reviews

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

Convert degenerate memcmp() to strncmp() in SQLite TimeMachine patch. BUG=178677 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=199794

Patch Set 1 #

Created: 7 years, 7 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+3 lines, -3 lines)			Patch
M	third_party/sqlite/amalgamation/sqlite3.c	View	1 chunk	+1 line, -1 line	0 comments	Download
M	third_party/sqlite/mac_time_machine.patch	View	1 chunk	+1 line, -1 line	0 comments	Download
M	third_party/sqlite/src/src/pager.c	View	1 chunk	+1 line, -1 line	0 comments	Download

Messages

Total messages: 6 (0 generated)

Expand Messages | Collapse Messages

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/shess@chromium.org/14651031/1

7 years, 7 months ago (2013-05-10 23:59:05 UTC) #3

commit-bot: I haz the power

Retried try job too often on linux_rel for step(s) interactive_ui_tests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=linux_rel&number=126656

7 years, 7 months ago (2013-05-11 01:10:24 UTC) #4

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/shess@chromium.org/14651031/1

7 years, 7 months ago (2013-05-13 16:54:06 UTC) #5

Message was sent while issue was closed.

Change committed as 199794

Expand Messages | Collapse Messages