Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(218)

Issue 14649013: Remove unused complex text fallback logic on Android (Closed)

Created:
7 years, 7 months ago by Xianzhu
Modified:
7 years, 7 months ago
CC:
blink-reviews, danakj, jamesr, Stephen Chennney, jeez, djsollen1, Peter Beverloo
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Visibility:
Public.

Description

Remove unused complex text fallback logic The original logic was needed when we used old harfbuzz and didn't have per-character font fallback machanism. First part for bug 236464. The other part is to remove FontCache::createFontPlatformData and related functions once Skia removes the extra fallback logic in SkTypeface::CreateFromName. BUG=236464 TEST=Results of layout tests about writing-mode, rtl, arabic, etc. should not be changed. Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=149627

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+22 lines, -32 lines) Patch
M Source/core/platform/graphics/chromium/FontCacheAndroid.cpp View 1 chunk +22 lines, -32 lines 0 comments Download

Messages

Total messages: 8 (0 generated)
Xianzhu
7 years, 7 months ago (2013-05-02 21:14:20 UTC) #1
eseidel
7 years, 7 months ago (2013-05-02 23:04:05 UTC) #2
jamesr
I'm not really an expert on this but lgtm as far as I can tell. ...
7 years, 7 months ago (2013-05-02 23:22:55 UTC) #3
Xianzhu
On 2013/05/02 23:22:55, jamesr wrote: > I'm not really an expert on this but lgtm ...
7 years, 7 months ago (2013-05-02 23:28:39 UTC) #4
jamesr
But do they run anywhere?
7 years, 7 months ago (2013-05-02 23:38:30 UTC) #5
Xianzhu
On 2013/05/02 23:38:30, jamesr wrote: > But do they run anywhere? For now layout tests ...
7 years, 7 months ago (2013-05-02 23:49:37 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/wangxianzhu@chromium.org/14649013/1
7 years, 7 months ago (2013-05-03 00:44:06 UTC) #7
commit-bot: I haz the power
7 years, 7 months ago (2013-05-03 01:12:17 UTC) #8
Message was sent while issue was closed.
Change committed as 149627

Powered by Google App Engine
This is Rietveld 408576698