Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(689)

Side by Side Diff: base/os_compat_android.cc

Issue 14649009: Android: Provide futimes() implementation using utimensat() (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: validate timeval input Created 7 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "base/os_compat_android.h" 5 #include "base/os_compat_android.h"
6 6
7 #include <asm/unistd.h>
7 #include <errno.h> 8 #include <errno.h>
8 #include <math.h> 9 #include <math.h>
9 #include <sys/stat.h> 10 #include <sys/stat.h>
11 #include <sys/syscall.h>
10 #include <time64.h> 12 #include <time64.h>
11 13
12 #include "base/rand_util.h" 14 #include "base/rand_util.h"
13 #include "base/stringprintf.h" 15 #include "base/stringprintf.h"
14 #include "base/strings/string_piece.h" 16 #include "base/strings/string_piece.h"
15 17
18 extern "C" {
16 // There is no futimes() avaiable in Bionic, so we provide our own 19 // There is no futimes() avaiable in Bionic, so we provide our own
17 // implementation until it is there. 20 // implementation until it is there.
18 extern "C" { 21 int futimes(int fd, const struct timeval tv[2]) {
22 if (tv == NULL)
23 return syscall(__NR_utimensat, fd, NULL, NULL, 0);
19 24
20 int futimes(int fd, const struct timeval tv[2]) { 25 if (tv[0].tv_usec < 0 || tv[0].tv_usec >= 1000000 ||
21 const std::string fd_path = base::StringPrintf("/proc/self/fd/%d", fd); 26 tv[1].tv_usec < 0 || tv[1].tv_usec >= 1000000) {
22 return utimes(fd_path.c_str(), tv); 27 errno = EINVAL;
28 return -1;
29 }
30
31 // Convert timeval to timespec.
32 struct timespec ts[2];
33 ts[0].tv_sec = tv[0].tv_sec;
34 ts[0].tv_nsec = tv[0].tv_usec * 1000;
35 ts[1].tv_sec = tv[1].tv_sec;
36 ts[1].tv_nsec = tv[1].tv_usec * 1000;
37 return syscall(__NR_utimensat, fd, NULL, ts, 0);
23 } 38 }
24 39
25 // Android has only timegm64() and no timegm(). 40 // Android has only timegm64() and no timegm().
26 // We replicate the behaviour of timegm() when the result overflows time_t. 41 // We replicate the behaviour of timegm() when the result overflows time_t.
27 time_t timegm(struct tm* const t) { 42 time_t timegm(struct tm* const t) {
28 // time_t is signed on Android. 43 // time_t is signed on Android.
29 static const time_t kTimeMax = ~(1 << (sizeof(time_t) * CHAR_BIT - 1)); 44 static const time_t kTimeMax = ~(1 << (sizeof(time_t) * CHAR_BIT - 1));
30 static const time_t kTimeMin = (1 << (sizeof(time_t) * CHAR_BIT - 1)); 45 static const time_t kTimeMin = (1 << (sizeof(time_t) * CHAR_BIT - 1));
31 time64_t result = timegm64(t); 46 time64_t result = timegm64(t);
32 if (result < kTimeMin || result > kTimeMax) 47 if (result < kTimeMin || result > kTimeMax)
(...skipping 113 matching lines...) Expand 10 before | Expand all | Expand 10 after
146 // The directory doesn't exist, but an error occured 161 // The directory doesn't exist, but an error occured
147 return NULL; 162 return NULL;
148 } 163 }
149 } 164 }
150 165
151 // We reached the max number of tries. 166 // We reached the max number of tries.
152 return NULL; 167 return NULL;
153 } 168 }
154 169
155 } // extern "C" 170 } // extern "C"
OLDNEW
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698