Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(150)

Issue 14646036: Get rid of DownloadItemImpl::UpdateProgress() (Closed)

Created:
7 years, 7 months ago by cmarcelo
Modified:
7 years, 7 months ago
Reviewers:
asanka
CC:
chromium-reviews, benjhayden+dwatch_chromium.org, asanka, darin-cc_chromium.org, jam, joi+watch-content_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Visibility:
Public.

Description

Get rid of DownloadItemImpl::UpdateProgress() Changed SavePackage and unit tests to use DestinationUpdated(). This function does the same work as UpdateProgress(). We stick to DestinationUpdated() since it's part of DownloadDestinationObserver interface (so already used elsewhere). This patch makes the interface implementation as public to allow access from SavePackage and unit tests. These functions were already public in the interface itself. BUG=239475 TEST=content_unittests and making sure chrome is built Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=200301

Patch Set 1 #

Patch Set 2 : Added "Patch from" to commit message #

Unified diffs Side-by-side diffs Delta from patch set Stats (+21 lines, -62 lines) Patch
M AUTHORS View 1 1 chunk +1 line, -0 lines 0 comments Download
M content/browser/download/download_item_impl.h View 1 2 chunks +7 lines, -14 lines 0 comments Download
M content/browser/download/download_item_impl.cc View 1 2 chunks +2 lines, -41 lines 0 comments Download
M content/browser/download/download_item_impl_unittest.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M content/browser/download/save_package.cc View 4 chunks +10 lines, -6 lines 0 comments Download

Messages

Total messages: 7 (0 generated)
cmarcelo
7 years, 7 months ago (2013-05-13 20:08:28 UTC) #1
asanka
cmarcelo: Did you sign the CLA or the CCLA? The CLA can be found at ...
7 years, 7 months ago (2013-05-13 20:35:55 UTC) #2
cmarcelo
Rebased and added the "Patch from". I'm already covered by the CLA signed by the ...
7 years, 7 months ago (2013-05-14 19:27:26 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/caio.de.oliveira.filho@intel.com/14646036/7001
7 years, 7 months ago (2013-05-14 19:52:00 UTC) #4
commit-bot: I haz the power
Retried try job too often on win_rel for step(s) unit_tests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=win_rel&number=148479
7 years, 7 months ago (2013-05-14 21:34:27 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/caio.de.oliveira.filho@intel.com/14646036/7001
7 years, 7 months ago (2013-05-15 14:25:22 UTC) #6
commit-bot: I haz the power
7 years, 7 months ago (2013-05-15 17:00:05 UTC) #7
Message was sent while issue was closed.
Change committed as 200301

Powered by Google App Engine
This is Rietveld 408576698