Issue 14646030: [Android] Fix md5sum for component build

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 14646030: [Android] Fix md5sum for component build (Closed)

Created:
7 years, 7 months ago by cjhopman

Modified:
7 years, 7 months ago

Reviewers:
Yaron

CC:
chromium-reviews, craigdh+watch_chromium.org, bulach+watch_chromium.org, yfriedman+watch_chromium.org, klundberg+watch_chromium.org, ilevy+watch_chromium.org, frankf+watch_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

[Android] Fix md5sum for component build In the component build, the device executable requires shared libraries to run. When building, use build/android/native_app_dependencies.gypi to copy the executable+libraries to a dist directory. Then, in android_commands.py we need to copy that directory to the device and specify LD_LIBRARY_PATH when running the executable. NOTRY=true BUG=158821 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=198183

Patch Set 1 #

Total comments: 1

Patch Set 2 : #

Created: 7 years, 7 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+37 lines, -22 lines)			Patch
	M	build/android/pylib/android_commands.py	View		3 chunks	+30 lines, -22 lines	0 comments	Download
	M	tools/android/md5sum/md5sum.gyp	View	1	1 chunk	+7 lines, -0 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

Yaron

lgtm https://codereview.chromium.org/14646030/diff/1/tools/android/md5sum/md5sum.gyp File tools/android/md5sum/md5sum.gyp (right): https://codereview.chromium.org/14646030/diff/1/tools/android/md5sum/md5sum.gyp#newcode15 tools/android/md5sum/md5sum.gyp:15: # and put alongside forwarder to simplify pushing ...

7 years, 7 months ago (2013-05-03 18:50:10 UTC) #2

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/cjhopman@chromium.org/14646030/6001

7 years, 7 months ago (2013-05-03 21:03:08 UTC) #3

Message was sent while issue was closed.

Change committed as 198183

Expand Messages | Collapse Messages