Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(142)

Issue 14644003: MediaStream API: Adding a username field to the RTCIceServer dictionary (Closed)

Created:
7 years, 7 months ago by Tommy Widenflycht
Modified:
7 years, 7 months ago
Reviewers:
abarth-chromium
CC:
juberti2, blink-reviews, jamesr, jeez, abarth_chromum.org
Visibility:
Public.

Description

MediaStream API: Adding a username field to the RTCIceServer dictionary This has been discussed and approved on the W3C email list. The main reason is the TURN URI Spec will(has) removed the username component. Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=149442

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+16 lines, -5 lines) Patch
M Source/Platform/chromium/public/WebRTCConfiguration.h View 1 chunk +1 line, -0 lines 0 comments Download
M Source/core/platform/chromium/support/WebRTCConfiguration.cpp View 1 chunk +6 lines, -0 lines 0 comments Download
M Source/core/platform/mediastream/RTCConfiguration.h View 1 chunk +6 lines, -3 lines 0 comments Download
M Source/modules/mediastream/RTCPeerConnection.cpp View 2 chunks +3 lines, -2 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
Tommy Widenflycht
7 years, 7 months ago (2013-04-30 11:43:06 UTC) #1
abarth-chromium
lgtm
7 years, 7 months ago (2013-04-30 16:17:46 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/tommyw@chromium.org/14644003/1
7 years, 7 months ago (2013-04-30 16:17:51 UTC) #3
commit-bot: I haz the power
7 years, 7 months ago (2013-04-30 16:51:21 UTC) #4
Message was sent while issue was closed.
Change committed as 149442

Powered by Google App Engine
This is Rietveld 408576698