cc: Introduce CompositorMode enum.

cc: Introduce CompositorMode enum.

The compositor can currently be run in single threaded or threaded mode.
The LayerTreeHost needs to be aware of the mode it is running in for 2
reasons:
1) To safely cast Proxy to SingleThreadProxy to make calls which
are supported only in single threaded mode.
2) To make decisions which require excluding browser compositors which
run only in single threaded mode.

The LayerTreeHost checks if it has the impl task runner to know the
mode of operation. Using the enum will make the purpose of this check
explicit at the call sites and allow the addition of the remote mode to
the compositor which will be run in the renderer but will not have an
impl task runner since all impl thread operations will be run on the
client compositor.

BUG=550687
CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel

Committed: https://crrev.com/19458bd9c403dddf7bfcb08ba106327792fa3a8a
Cr-Commit-Position: refs/heads/master@{#363708}

[Khushal, 2015-11-25 19:45:27]

Description was changed from

==========
cc: Introduce CompositorMode enum.

The compositor can currently be run in single threaded or threaded mode.
The LayerTreeHost needs to be aware of the mode it is running in for 2
reasons:
1) To safely cast Proxy to SingleThreadProxy to make calls which
are supported only in single threaded mode.
2) To make decisions which require excluding browser compositors which
run only in single threaded mode.

The LayerTreeHost checks if it has the impl task runner to know the
mode of operation. Using the enum will make the purpose of this check
explicit at the call sites and allow the addition of the remote mode to
the compositor which will be run in the renderer but will not have an
impl task runner since all impl thread operations will be run on the
client compositor.

BUG=550687
==========

to

==========
cc: Introduce CompositorMode enum.

The compositor can currently be run in single threaded or threaded mode.
The LayerTreeHost needs to be aware of the mode it is running in for 2
reasons:
1) To safely cast Proxy to SingleThreadProxy to make calls which
are supported only in single threaded mode.
2) To make decisions which require excluding browser compositors which
run only in single threaded mode.

The LayerTreeHost checks if it has the impl task runner to know the
mode of operation. Using the enum will make the purpose of this check
explicit at the call sites and allow the addition of the remote mode to
the compositor which will be run in the renderer but will not have an
impl task runner since all impl thread operations will be run on the
client compositor.

BUG=550687
CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel
==========

[Khushal, 2015-11-25 20:30:22]

Description was changed from

==========
cc: Introduce CompositorMode enum.

The compositor can currently be run in single threaded or threaded mode.
The LayerTreeHost needs to be aware of the mode it is running in for 2
reasons:
1) To safely cast Proxy to SingleThreadProxy to make calls which
are supported only in single threaded mode.
2) To make decisions which require excluding browser compositors which
run only in single threaded mode.

The LayerTreeHost checks if it has the impl task runner to know the
mode of operation. Using the enum will make the purpose of this check
explicit at the call sites and allow the addition of the remote mode to
the compositor which will be run in the renderer but will not have an
impl task runner since all impl thread operations will be run on the
client compositor.

BUG=550687
CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel
==========

to

==========
cc: Introduce CompositorMode enum.

The compositor can currently be run in single threaded or threaded mode.
The LayerTreeHost needs to be aware of the mode it is running in for 2
reasons:
1) To safely cast Proxy to SingleThreadProxy to make calls which
are supported only in single threaded mode.
2) To make decisions which require excluding browser compositors which
run only in single threaded mode.

The LayerTreeHost checks if it has the impl task runner to know the
mode of operation. Using the enum will make the purpose of this check
explicit at the call sites and allow the addition of the remote mode to
the compositor which will be run in the renderer but will not have an
impl task runner since all impl thread operations will be run on the
client compositor.

BUG=550687
CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel
==========

[Khushal, 2015-11-25 20:30:22]

khushalsagar@chromium.org changed reviewers:
+ vmpstr@chromium.org

[Khushal, 2015-12-05 00:45:16]

On 2015/11/25 19:56:47, Khushal wrote:

friendly ping. :D

[vmpstr, 2015-12-07 18:50:09]

https://codereview.chromium.org/1464313007/diff/20001/cc/test/layer_tree_test.cc
File cc/test/layer_tree_test.cc (right):

https://codereview.chromium.org/1464313007/diff/20001/cc/test/layer_tree_test...
cc/test/layer_tree_test.cc:933: CompositorMode mode;
you can just 

CompositorMode mode = impl_thread ? ... : ...;

https://codereview.chromium.org/1464313007/diff/20001/cc/trees/compositor_mode.h
File cc/trees/compositor_mode.h (right):

https://codereview.chromium.org/1464313007/diff/20001/cc/trees/compositor_mod...
cc/trees/compositor_mode.h:12: Threaded,
I'm kind of wondering if this should be MultiThreaded, but I guess this is
consistent with CreateThreaded/CreateSingleThreaded.

Can you leave a comment above the enum explaining where this is used and what
this affects?

https://codereview.chromium.org/1464313007/diff/20001/cc/trees/layer_tree_hos...
File cc/trees/layer_tree_host.cc (right):

https://codereview.chromium.org/1464313007/diff/20001/cc/trees/layer_tree_hos...
cc/trees/layer_tree_host.cc:1263:
DCHECK(task_runner_provider_->HasImplThread());
Can you change this function to:

{
  DCHECK(compositor_mode_ != CompositorMode::Threaded ||
         task_runner_provider_->HasImplThread());
  return compositor_mode_ == CompositorMode::Threaded;
}

https://codereview.chromium.org/1464313007/diff/20001/cc/trees/layer_tree_host.h
File cc/trees/layer_tree_host.h (right):

https://codereview.chromium.org/1464313007/diff/20001/cc/trees/layer_tree_hos...
cc/trees/layer_tree_host.h:421: const CompositorMode compositor_mode_;
Functions before variables, please.

[Khushal, 2015-12-07 21:49:26]

https://codereview.chromium.org/1464313007/diff/20001/cc/test/layer_tree_test.cc
File cc/test/layer_tree_test.cc (right):

https://codereview.chromium.org/1464313007/diff/20001/cc/test/layer_tree_test...
cc/test/layer_tree_test.cc:933: CompositorMode mode;
On 2015/12/07 18:50:08, vmpstr wrote:
> you can just 
> 
> CompositorMode mode = impl_thread ? ... : ...;

That makes sense. Done.

https://codereview.chromium.org/1464313007/diff/20001/cc/trees/compositor_mode.h
File cc/trees/compositor_mode.h (right):

https://codereview.chromium.org/1464313007/diff/20001/cc/trees/compositor_mod...
cc/trees/compositor_mode.h:12: Threaded,
On 2015/12/07 18:50:09, vmpstr wrote:
> I'm kind of wondering if this should be MultiThreaded, but I guess this is
> consistent with CreateThreaded/CreateSingleThreaded.
> 

Yup. Wanted to keep it consistent with the LayerTreeHost Create methods.

> Can you leave a comment above the enum explaining where this is used and what
> this affects?
Done.

https://codereview.chromium.org/1464313007/diff/20001/cc/trees/layer_tree_hos...
File cc/trees/layer_tree_host.cc (right):

https://codereview.chromium.org/1464313007/diff/20001/cc/trees/layer_tree_hos...
cc/trees/layer_tree_host.cc:1263:
DCHECK(task_runner_provider_->HasImplThread());
On 2015/12/07 18:50:09, vmpstr wrote:
> Can you change this function to:
> 
> {
>   DCHECK(compositor_mode_ != CompositorMode::Threaded ||
>          task_runner_provider_->HasImplThread());
>   return compositor_mode_ == CompositorMode::Threaded;
> }

Done.

https://codereview.chromium.org/1464313007/diff/20001/cc/trees/layer_tree_host.h
File cc/trees/layer_tree_host.h (right):

https://codereview.chromium.org/1464313007/diff/20001/cc/trees/layer_tree_hos...
cc/trees/layer_tree_host.h:421: const CompositorMode compositor_mode_;
On 2015/12/07 18:50:09, vmpstr wrote:
> Functions before variables, please.

Done.

[vmpstr, 2015-12-07 22:00:58]

lgtm

[Khushal, 2015-12-07 22:02:34]

The CQ bit was checked by khushalsagar@chromium.org

[commit-bot: I haz the power, 2015-12-07 22:06:18]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1464313007/60001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1464313007/60001

[commit-bot: I haz the power, 2015-12-07 23:01:32]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-12-07 23:01:32]

Try jobs failed on following builders:
  android_arm64_dbg_recipe on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/android_arm64_d...)
  android_clang_dbg_recipe on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/android_clang_d...)
  android_compile_dbg on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/android_compile...)

[Khushal, 2015-12-07 23:17:17]

khushalsagar@chromium.org changed reviewers:
+ dtrainor@chromium.org

[David Trainor- moved to gerrit, 2015-12-07 23:25:41]

lgtm

[Khushal, 2015-12-07 23:26:11]

The CQ bit was checked by khushalsagar@chromium.org

[Khushal, 2015-12-07 23:26:11]

The patchset sent to the CQ was uploaded after l-g-t-m from vmpstr@chromium.org
Link to the patchset: https://chromiumcodereview.appspot.com/1464313007/#ps60002
(title: "Change ui::MockLayerTreeHost")

[commit-bot: I haz the power, 2015-12-07 23:26:38]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1464313007/60002
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1464313007/60002

[commit-bot: I haz the power, 2015-12-08 00:40:59]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-12-08 00:41:00]

Try jobs failed on following builders:
  linux_chromium_compile_dbg_ng on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  linux_chromium_rel_ng on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[Khushal, 2015-12-08 01:02:12]

The CQ bit was checked by khushalsagar@chromium.org

[commit-bot: I haz the power, 2015-12-08 01:08:24]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1464313007/60002
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1464313007/60002

[commit-bot: I haz the power, 2015-12-08 02:19:11]

Description was changed from

==========
cc: Introduce CompositorMode enum.

The compositor can currently be run in single threaded or threaded mode.
The LayerTreeHost needs to be aware of the mode it is running in for 2
reasons:
1) To safely cast Proxy to SingleThreadProxy to make calls which
are supported only in single threaded mode.
2) To make decisions which require excluding browser compositors which
run only in single threaded mode.

The LayerTreeHost checks if it has the impl task runner to know the
mode of operation. Using the enum will make the purpose of this check
explicit at the call sites and allow the addition of the remote mode to
the compositor which will be run in the renderer but will not have an
impl task runner since all impl thread operations will be run on the
client compositor.

BUG=550687
CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel
==========

to

==========
cc: Introduce CompositorMode enum.

The compositor can currently be run in single threaded or threaded mode.
The LayerTreeHost needs to be aware of the mode it is running in for 2
reasons:
1) To safely cast Proxy to SingleThreadProxy to make calls which
are supported only in single threaded mode.
2) To make decisions which require excluding browser compositors which
run only in single threaded mode.

The LayerTreeHost checks if it has the impl task runner to know the
mode of operation. Using the enum will make the purpose of this check
explicit at the call sites and allow the addition of the remote mode to
the compositor which will be run in the renderer but will not have an
impl task runner since all impl thread operations will be run on the
client compositor.

BUG=550687
CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel
==========

[commit-bot: I haz the power, 2015-12-08 02:19:12]

Committed patchset #5 (id:60002)

[commit-bot: I haz the power, 2015-12-08 02:20:15]

Description was changed from

==========
cc: Introduce CompositorMode enum.

The compositor can currently be run in single threaded or threaded mode.
The LayerTreeHost needs to be aware of the mode it is running in for 2
reasons:
1) To safely cast Proxy to SingleThreadProxy to make calls which
are supported only in single threaded mode.
2) To make decisions which require excluding browser compositors which
run only in single threaded mode.

The LayerTreeHost checks if it has the impl task runner to know the
mode of operation. Using the enum will make the purpose of this check
explicit at the call sites and allow the addition of the remote mode to
the compositor which will be run in the renderer but will not have an
impl task runner since all impl thread operations will be run on the
client compositor.

BUG=550687
CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel
==========

to

==========
cc: Introduce CompositorMode enum.

The compositor can currently be run in single threaded or threaded mode.
The LayerTreeHost needs to be aware of the mode it is running in for 2
reasons:
1) To safely cast Proxy to SingleThreadProxy to make calls which
are supported only in single threaded mode.
2) To make decisions which require excluding browser compositors which
run only in single threaded mode.

The LayerTreeHost checks if it has the impl task runner to know the
mode of operation. Using the enum will make the purpose of this check
explicit at the call sites and allow the addition of the remote mode to
the compositor which will be run in the renderer but will not have an
impl task runner since all impl thread operations will be run on the
client compositor.

BUG=550687
CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel

Committed: https://crrev.com/19458bd9c403dddf7bfcb08ba106327792fa3a8a
Cr-Commit-Position: refs/heads/master@{#363708}
==========

[commit-bot: I haz the power, 2015-12-08 02:20:19]

Patchset 5 (id:??) landed as
https://crrev.com/19458bd9c403dddf7bfcb08ba106327792fa3a8a
Cr-Commit-Position: refs/heads/master@{#363708}