content/renderer/p2p/filtering_network_manager.h - Issue 1464183002: media: Simplify MediaPermissionDispatcher.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/renderer/p2p/filtering_network_manager.h

Issue 1464183002: media: Simplify MediaPermissionDispatcher. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: comments addressed Created 5 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: content/renderer/p2p/filtering_network_manager.h

diff --git a/content/renderer/p2p/filtering_network_manager.h b/content/renderer/p2p/filtering_network_manager.h

index 167666af8f8ef903c95254fae69a68bcb3ad6030..8802fda11cf72ad3d67f927cd40c68d3f772b7f4 100644

--- a/content/renderer/p2p/filtering_network_manager.h

+++ b/content/renderer/p2p/filtering_network_manager.h

@@ -41,7 +41,7 @@ class FilteringNetworkManager : public rtc::NetworkManagerBase,

CONTENT_EXPORT FilteringNetworkManager(

rtc::NetworkManager* network_manager,

const GURL& requesting_origin,

- scoped_ptr<media::MediaPermission> media_permission);

+ media::MediaPermission* media_permission);

CONTENT_EXPORT ~FilteringNetworkManager() override;

@@ -93,7 +93,7 @@ class FilteringNetworkManager : public rtc::NetworkManagerBase,

// The class is created by the signaling thread but used by the worker thread.

base::ThreadChecker thread_checker_;

- scoped_ptr<media::MediaPermission> media_permission_;

+ media::MediaPermission* media_permission_;

int pending_permission_checks_ = 0;