chrome/browser/download/chrome_download_manager_delegate_unittest.cc - Issue 14640020: [Resumption 9/11] Handle filename determination for resumed downloads.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/download/chrome_download_manager_delegate_unittest.cc

Issue 14640020: [Resumption 9/11] Handle filename determination for resumed downloads. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Address comments Created 7 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/download/chrome_download_manager_delegate.cc ('k') | chrome/browser/download/download_target_determiner.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/download/chrome_download_manager_delegate_unittest.cc

diff --git a/chrome/browser/download/chrome_download_manager_delegate_unittest.cc b/chrome/browser/download/chrome_download_manager_delegate_unittest.cc

index d2dc590f5fc5c774fa5de28df305cee63fed589e..eacd264861881a4c2d420b46b392dfbbbde69bf9 100644

--- a/chrome/browser/download/chrome_download_manager_delegate_unittest.cc

+++ b/chrome/browser/download/chrome_download_manager_delegate_unittest.cc

@@ -13,6 +13,7 @@

#include "chrome/test/base/chrome_render_view_host_test_harness.h"

#include "chrome/test/base/testing_pref_service_syncable.h"

#include "chrome/test/base/testing_profile.h"

+#include "content/public/browser/download_interrupt_reasons.h"

#include "content/public/browser/web_contents.h"

#include "content/public/browser/web_contents_delegate.h"

#include "content/public/test/mock_download_item.h"

@@ -220,10 +221,14 @@ content::MockDownloadItem*

.WillByDefault(ReturnRefOfCopy(std::string()));

ON_CALL(*item, GetId())

.WillByDefault(Return(id));

+ ON_CALL(*item, GetLastReason())

+ .WillByDefault(Return(content::DOWNLOAD_INTERRUPT_REASON_NONE));

ON_CALL(*item, GetReferrerUrl())

.WillByDefault(ReturnRefOfCopy(GURL()));

ON_CALL(*item, GetState())

.WillByDefault(Return(DownloadItem::IN_PROGRESS));

+ ON_CALL(*item, GetTargetFilePath())

+ .WillByDefault(ReturnRefOfCopy(base::FilePath()));

ON_CALL(*item, GetTransitionType())

.WillByDefault(Return(content::PAGE_TRANSITION_LINK));

ON_CALL(*item, GetWebContents())