Issue 14636012: Move ShellWindowGeometryCache into apps

Issue 14636012: Move ShellWindowGeometryCache into apps (Closed)

Created:
7 years, 7 months ago by benwells

Modified:
7 years, 7 months ago

Reviewers:
Yoyo Zhou, Elliot Glaysher

CC:
chromium-reviews, tfarina, Aaron Boodman, jeremya+watch_chromium.org, chromium-apps-reviews_chromium.org, chrome-apps-syd-reviews_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

Move ShellWindowGeometryCache into apps BUG=159366 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=200770

Patch Set 2 : PKS dependency #

Total comments: 2

Patch Set 3 : Rebase #

Created: 7 years, 7 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+118 lines, -641 lines)			Patch
M	apps/apps.gypi	View		1 chunk	+2 lines, -0 lines	0 comments	Download
A +	apps/shell_window_geometry_cache.h	View	1 2	5 chunks	+37 lines, -6 lines	0 comments	Download
A +	apps/shell_window_geometry_cache.cc	View	1 2	5 chunks	+64 lines, -8 lines	0 comments	Download
A +	apps/shell_window_geometry_cache_unittest.cc	View		3 chunks	+5 lines, -5 lines	0 comments	Download
M	chrome/browser/extensions/extension_system.h	View	1 2	5 chunks	+0 lines, -8 lines	0 comments	Download
M	chrome/browser/extensions/extension_system.cc	View	1 2	4 chunks	+0 lines, -13 lines	0 comments	Download
D	chrome/browser/extensions/shell_window_geometry_cache.h	View		1 chunk	+0 lines, -106 lines	0 comments	Download
D	chrome/browser/extensions/shell_window_geometry_cache.cc	View		1 chunk	+0 lines, -219 lines	0 comments	Download
D	chrome/browser/extensions/shell_window_geometry_cache_unittest.cc	View		1 chunk	+0 lines, -256 lines	0 comments	Download
M	chrome/browser/extensions/test_extension_system.h	View	1 2	2 chunks	+0 lines, -2 lines	0 comments	Download
M	chrome/browser/extensions/test_extension_system.cc	View	1 2	3 chunks	+1 line, -8 lines	0 comments	Download
M	chrome/browser/profiles/profile_dependency_manager.cc	View	1 2	2 chunks	+2 lines, -0 lines	0 comments	Download
M	chrome/browser/ui/extensions/shell_window.cc	View	1 2	3 chunks	+6 lines, -7 lines	0 comments	Download
M	chrome/chrome_browser_extensions.gypi	View	1 2	1 chunk	+0 lines, -2 lines	0 comments	Download
M	chrome/chrome_tests_unit.gypi	View	1 2	2 chunks	+1 line, -1 line	0 comments	Download

Messages

Total messages: 6 (0 generated)

Expand Messages | Collapse Messages

benwells

I see this will change soon with the ExtensionPrefs change in queue, but that update ...

7 years, 7 months ago (2013-05-15 22:35:18 UTC) #1

Yoyo Zhou

LGTM with nit You can also add 179951 to BUG=. https://codereview.chromium.org/14636012/diff/5001/apps/shell_window_geometry_cache.h File apps/shell_window_geometry_cache.h (right): https://codereview.chromium.org/14636012/diff/5001/apps/shell_window_geometry_cache.h#newcode65 ...

7 years, 7 months ago (2013-05-15 22:52:11 UTC) #2

benwells

+erg for profile_dependency_manager change. https://codereview.chromium.org/14636012/diff/5001/apps/shell_window_geometry_cache.h File apps/shell_window_geometry_cache.h (right): https://codereview.chromium.org/14636012/diff/5001/apps/shell_window_geometry_cache.h#newcode65 apps/shell_window_geometry_cache.h:65: // Returns the instance for ...

7 years, 7 months ago (2013-05-16 11:05:37 UTC) #3

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/benwells@chromium.org/14636012/15001

7 years, 7 months ago (2013-05-16 22:22:51 UTC) #5

Message was sent while issue was closed.

Change committed as 200770

Expand Messages | Collapse Messages