chrome/android/java/src/org/chromium/chrome/browser/contextualsearch/ContextualSearchPolicy.java - Issue 1463583004: [Contextual Search] Trigger translation on long-press.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/android/java/src/org/chromium/chrome/browser/contextualsearch/ContextualSearchPolicy.java

Issue 1463583004: [Contextual Search] Trigger translation on long-press. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Tiny tweak. Created 5 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/android/java/src/org/chromium/chrome/browser/contextualsearch/ContextualSearchManager.java ('k') | chrome/android/java/src/org/chromium/chrome/browser/contextualsearch/ContextualSearchRequest.java » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/android/java/src/org/chromium/chrome/browser/contextualsearch/ContextualSearchPolicy.java

diff --git a/chrome/android/java/src/org/chromium/chrome/browser/contextualsearch/ContextualSearchPolicy.java b/chrome/android/java/src/org/chromium/chrome/browser/contextualsearch/ContextualSearchPolicy.java

index 089109d848191ceb98a2d7e161d42b3384da7dc8..3041cb31c0653b12ac7a7b2844cd46eec10e9020 100644

--- a/chrome/android/java/src/org/chromium/chrome/browser/contextualsearch/ContextualSearchPolicy.java

+++ b/chrome/android/java/src/org/chromium/chrome/browser/contextualsearch/ContextualSearchPolicy.java

@@ -472,6 +472,16 @@ class ContextualSearchPolicy {

}

/**

+ * @return Whether forcing a translation Onebox based on auto-detection of the source language

+ * is disabled.

+ */

+ boolean disableAutoDetectTranslationOnebox() {

+ if (disableForceTranslationOnebox()) return true;

+ return ContextualSearchFieldTrial.disableAutoDetectTranslationOnebox();

+ }

+ /**

* Sets the limit for the tap triggered promo.

@VisibleForTesting