Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3402)

Unified Diff: base/threading/thread_id_name_manager_unittest.cc

Issue 14634009: Move Thread Name Mapping into ThreadFunc. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 7 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « base/threading/thread_id_name_manager.cc ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: base/threading/thread_id_name_manager_unittest.cc
diff --git a/base/threading/thread_id_name_manager_unittest.cc b/base/threading/thread_id_name_manager_unittest.cc
index 08f1ea705542654f1e18a07d549ee684ccba7d3c..37773018a0ebdfff1888ee11399aa1cf87f2077b 100644
--- a/base/threading/thread_id_name_manager_unittest.cc
+++ b/base/threading/thread_id_name_manager_unittest.cc
@@ -41,9 +41,10 @@ TEST_F(ThreadIdNameManagerTest, RemoveThreads) {
thread_b.Start();
thread_b.Stop();
}
- thread_a.Stop();
-
EXPECT_STREQ(kAThread, manager->GetName(thread_a.thread_id()));
+
+ thread_a.Stop();
+ EXPECT_STREQ("", manager->GetName(thread_a.thread_id()));
}
TEST_F(ThreadIdNameManagerTest, RestartThread) {
@@ -52,12 +53,13 @@ TEST_F(ThreadIdNameManagerTest, RestartThread) {
thread_a.Start();
base::PlatformThreadId a_id = thread_a.thread_id();
- thread_a.Stop();
EXPECT_STREQ(kAThread, manager->GetName(a_id));
+ thread_a.Stop();
thread_a.Start();
+ EXPECT_STREQ("", manager->GetName(a_id));
+ EXPECT_STREQ(kAThread, manager->GetName(thread_a.thread_id()));
thread_a.Stop();
- EXPECT_STREQ(kAThread, manager->GetName(a_id));
}
TEST_F(ThreadIdNameManagerTest, ThreadNameInterning) {
« no previous file with comments | « base/threading/thread_id_name_manager.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698