Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(12)

Issue 14632007: Add loadedNonEmptyDocument flag in iframe for Resource Timing (Closed)

Created:
7 years, 7 months ago by pan deng
Modified:
7 years, 7 months ago
CC:
blink-reviews, Nate Chapin, eae+blinkwatch, gavinp+loader_chromium.org, esprehn
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Visibility:
Public.

Description

Add loadedNonEmptyDocument flag in iframe for Resource Timing Sometimes iframe src is blank in markup, and then will be set a real URL via script, Resource Timing would like to populate resource fetched from the real URL, but avoid the self navigation after that, so this change add a flag loadedNonEmptyDocument to achieve that. Contributed by pan.deng@intel.com BUG=236180 TBR=japhet Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=150353

Patch Set 1 #

Patch Set 2 : Satisfy lighttpd on windows, and handle overlap timestamps #

Messages

Total messages: 13 (0 generated)
pan deng
Hi japhet, Trybot and CQ don't work for me in CL https://codereview.chromium.org/14054023/, I consulted dpranke, ...
7 years, 7 months ago (2013-05-09 03:24:46 UTC) #1
eseidel
7 years, 7 months ago (2013-05-09 03:26:17 UTC) #2
Nate Chapin
lgtm
7 years, 7 months ago (2013-05-09 16:07:23 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/pan.deng@chromium.org/14632007/1
7 years, 7 months ago (2013-05-09 16:07:29 UTC) #4
commit-bot: I haz the power
Retried try job too often on win_layout_rel for step(s) webkit_tests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=win_layout_rel&number=4504
7 years, 7 months ago (2013-05-09 18:03:36 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/pan.deng@chromium.org/14632007/1
7 years, 7 months ago (2013-05-09 23:43:56 UTC) #6
commit-bot: I haz the power
Retried try job too often on win_layout_rel for step(s) webkit_tests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=win_layout_rel&number=4571
7 years, 7 months ago (2013-05-10 03:09:32 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/pan.deng@chromium.org/14632007/1
7 years, 7 months ago (2013-05-11 10:28:47 UTC) #8
pan deng
James and Tony, This patch failed on win layout tests because two reasons. 1) php ...
7 years, 7 months ago (2013-05-14 12:40:55 UTC) #9
James Simonsen
lgtm
7 years, 7 months ago (2013-05-14 17:36:43 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/pan.deng@chromium.org/14632007/38001
7 years, 7 months ago (2013-05-14 17:37:02 UTC) #11
James Simonsen
BTW, On 2013/05/14 12:40:55, pan deng wrote: > or time accurate not good enough in ...
7 years, 7 months ago (2013-05-14 17:38:22 UTC) #12
commit-bot: I haz the power
7 years, 7 months ago (2013-05-14 20:43:22 UTC) #13
Message was sent while issue was closed.
Change committed as 150353

Powered by Google App Engine
This is Rietveld 408576698