Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(18)

Unified Diff: ui/message_center/notification.h

Issue 14631005: Enable users of NotificationUIManager to specify binary images. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Rebase for relanding. Created 7 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « ui/message_center/message_center_tray_unittest.cc ('k') | ui/message_center/notification.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: ui/message_center/notification.h
diff --git a/ui/message_center/notification.h b/ui/message_center/notification.h
index 5f7ee12a4523e48ca4464f154fe476220176a1af..c6c43b9f517047fccb8d33bf962879c2fb1b7869 100644
--- a/ui/message_center/notification.h
+++ b/ui/message_center/notification.h
@@ -32,16 +32,45 @@ struct MESSAGE_CENTER_EXPORT ButtonInfo {
ButtonInfo(const string16& title);
};
+class MESSAGE_CENTER_EXPORT RichNotificationData {
+ public:
+ RichNotificationData();
+ RichNotificationData(const RichNotificationData& other);
+ ~RichNotificationData();
+
+ int priority;
+ bool never_timeout;
+ base::Time timestamp;
+ string16 expanded_message;
+ gfx::Image image;
+ std::vector<NotificationItem> items;
+ std::vector<ButtonInfo> buttons;
+};
+
class MESSAGE_CENTER_EXPORT Notification {
public:
Notification(NotificationType type,
const std::string& id,
const string16& title,
const string16& message,
+ const gfx::Image& icon,
const string16& display_source,
const std::string& extension_id,
const DictionaryValue* optional_fields, // May be NULL.
NotificationDelegate* delegate); // May be NULL.
+
+ Notification(NotificationType type,
+ const std::string& id,
+ const string16& title,
+ const string16& message,
+ const gfx::Image& icon,
+ const string16& display_source,
+ const std::string& extension_id,
+ const RichNotificationData& optional_fields,
+ NotificationDelegate* delegate);
+
+ Notification(const Notification& other);
+ Notification& operator=(const Notification& other);
virtual ~Notification();
// Copies the internal on-memory state from |base|, i.e. shown_as_popup,
@@ -52,26 +81,37 @@ class MESSAGE_CENTER_EXPORT Notification {
const std::string& id() const { return id_; }
const string16& title() const { return title_; }
const string16& message() const { return message_; }
+
+ // A display string for the source of the notification.
const string16& display_source() const { return display_source_; }
const std::string& extension_id() const { return extension_id_; }
+ void set_extension_id(const std::string& extension_id) {
+ extension_id_ = extension_id;
+ }
// Begin unpacked values from optional_fields.
- int priority() const { return priority_; }
- base::Time timestamp() const { return timestamp_; }
- const string16& expanded_message() const { return expanded_message_; }
- const std::vector<NotificationItem>& items() const { return items_; }
+ int priority() const { return optional_fields_.priority; }
+ base::Time timestamp() const { return optional_fields_.timestamp; }
+ const string16& expanded_message() const {
+ return optional_fields_.expanded_message;
+ }
+ const std::vector<NotificationItem>& items() const {
+ return optional_fields_.items;
+ }
// End unpacked values.
// Images fetched asynchronously.
const gfx::Image& icon() const { return icon_; }
void set_icon(const gfx::Image& icon) { icon_ = icon; }
- const gfx::Image& image() const { return image_; }
- void set_image(const gfx::Image& image) { image_ = image; }
+ const gfx::Image& image() const { return optional_fields_.image; }
+ void set_image(const gfx::Image& image) { optional_fields_.image = image; }
// Buttons, with icons fetched asynchronously.
- const std::vector<ButtonInfo>& buttons() const { return buttons_; }
- bool SetButtonIcon(size_t index, const gfx::Image& icon);
+ const std::vector<ButtonInfo>& buttons() const {
+ return optional_fields_.buttons;
+ }
+ void SetButtonIcon(size_t index, const gfx::Image& icon);
bool shown_as_popup() const { return shown_as_popup_; }
void set_shown_as_popup(bool shown_as_popup) {
@@ -90,38 +130,56 @@ class MESSAGE_CENTER_EXPORT Notification {
// The notification with lesser serial_number is considered 'older'.
unsigned serial_number() { return serial_number_; }
- bool never_timeout() const { return never_timeout_; }
- NotificationDelegate* delegate() { return delegate_.get(); }
+ // Marks this explicitly to prevent the timeout dismiss of notification.
+ // This is used by webkit notifications to keep the existing behavior.
+ void set_never_timeout(bool never_timeout) {
+ optional_fields_.never_timeout = never_timeout;
+ }
- private:
- // Unpacks the provided |optional_fields| and applies the values to override
- // the notification's data members.
- void ApplyOptionalFields(const DictionaryValue* optional_fields);
+ bool never_timeout() const { return optional_fields_.never_timeout; }
+ NotificationDelegate* delegate() const { return delegate_.get(); }
+ const RichNotificationData& rich_notification_data() const {
+ return optional_fields_;
+ }
+
+ // Delegate actions.
+ void Display() const { delegate()->Display(); }
+ void Error() const { delegate()->Error(); }
+ bool HasClickedListener() const { return delegate()->HasClickedListener(); }
+ void Click() const { delegate()->Click(); }
+ void ButtonClick(int index) const { delegate()->ButtonClick(index); }
+ void Close(bool by_user) const { delegate()->Close(by_user); }
+ protected:
+ // The type of notification we'd like displayed.
NotificationType type_;
+
std::string id_;
string16 title_;
string16 message_;
+
+ // Image data for the associated icon, used by Ash when available.
+ gfx::Image icon_;
+
+ // The display string for the source of the notification. Could be
+ // the same as origin_url_, or the name of an extension.
string16 display_source_;
+
+ private:
+ // Unpacks the provided |optional_fields| and applies the values to override
+ // the notification's data members.
+ void ApplyOptionalFields(const DictionaryValue* optional_fields);
+
std::string extension_id_;
- int priority_;
- base::Time timestamp_;
unsigned serial_number_;
- string16 expanded_message_;
- std::vector<NotificationItem> items_;
- gfx::Image icon_;
- gfx::Image image_;
- std::vector<ButtonInfo> buttons_;
+ RichNotificationData optional_fields_;
bool shown_as_popup_; // True if this has been shown as a popup.
bool is_read_; // True if this has been seen in the message center.
bool is_expanded_; // True if this has been expanded in the message center.
- bool never_timeout_; // True if it doesn't timeout when it appears as a toast.
// A proxy object that allows access back to the JavaScript object that
// represents the notification, for firing events.
scoped_refptr<NotificationDelegate> delegate_;
-
- DISALLOW_COPY_AND_ASSIGN(Notification);
};
} // namespace message_center
« no previous file with comments | « ui/message_center/message_center_tray_unittest.cc ('k') | ui/message_center/notification.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698