Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(334)

Unified Diff: ui/message_center/message_center.h

Issue 14631005: Enable users of NotificationUIManager to specify binary images. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Rebase for relanding. Created 7 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « ui/message_center/fake_message_center.cc ('k') | ui/message_center/message_center_impl.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: ui/message_center/message_center.h
diff --git a/ui/message_center/message_center.h b/ui/message_center/message_center.h
index 7be6cc818831b5cd17a6de627b0851a39c248d89..ff247d3b4b0a0d7261e560241fdf26c884c9be87 100644
--- a/ui/message_center/message_center.h
+++ b/ui/message_center/message_center.h
@@ -84,32 +84,13 @@ class MESSAGE_CENTER_EXPORT MessageCenter {
// Basic operations of notification: add/remove/update.
- // Adds a new notification. |id| is a unique identifier, used to update or
- // remove notifications. |title| and |meesage| describe the notification text.
- // Use SetNotificationIcon, SetNotificationImage, or SetNotificationButtonIcon
- // to set images. If |extension_id| is provided then 'Disable extension' will
- // appear in a dropdown menu and the id will be used to disable notifications
- // from the extension. Otherwise if |display_source| is provided, a menu item
- // showing the source and allowing notifications from that source to be
- // disabled will be shown. All actual disabling is handled by the Delegate.
- virtual void AddNotification(NotificationType type,
- const std::string& id,
- const string16& title,
- const string16& message,
- const string16& display_source,
- const std::string& extension_id,
- const base::DictionaryValue* optional_fields,
- NotificationDelegate* delegate) = 0;
+ // Adds a new notification.
+ virtual void AddNotification(scoped_ptr<Notification> notification) = 0;
// Updates an existing notification with id = old_id and set its id to new_id.
- // |delegate| and |optional_fields| can be NULL in case of no updates on
- // those fields.
- virtual void UpdateNotification(const std::string& old_id,
- const std::string& new_id,
- const string16& title,
- const string16& message,
- const base::DictionaryValue* optional_fields,
- NotificationDelegate* delegate) = 0;
+ virtual void UpdateNotification(
+ const std::string& old_id,
+ scoped_ptr<Notification> new_notification) = 0;
// Removes an existing notification.
virtual void RemoveNotification(const std::string& id, bool by_user) = 0;
« no previous file with comments | « ui/message_center/fake_message_center.cc ('k') | ui/message_center/message_center_impl.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698