chrome/browser/notifications/sync_notifier/chrome_notifier_service_unittest.cc - Issue 14631005: Enable users of NotificationUIManager to specify binary images.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/notifications/sync_notifier/chrome_notifier_service_unittest.cc

Issue 14631005: Enable users of NotificationUIManager to specify binary images. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Rebase for relanding. Created 7 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/notifications/notification_ui_manager_mac.mm ('k') | chrome/browser/notifications/sync_notifier/synced_notification.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/notifications/sync_notifier/chrome_notifier_service_unittest.cc

diff --git a/chrome/browser/notifications/sync_notifier/chrome_notifier_service_unittest.cc b/chrome/browser/notifications/sync_notifier/chrome_notifier_service_unittest.cc

index 2fc4db797820039c946416bdfc0c790f6dc6dac5..79f5aef0868e67513f571fbff36fdf53599a429b 100644

--- a/chrome/browser/notifications/sync_notifier/chrome_notifier_service_unittest.cc

+++ b/chrome/browser/notifications/sync_notifier/chrome_notifier_service_unittest.cc

@@ -8,6 +8,7 @@

#include "base/utf_string_conversions.h"

#include "base/values.h"

#include "chrome/browser/notifications/notification.h"

+#include "chrome/browser/notifications/notification_test_util.h"

#include "chrome/browser/notifications/notification_ui_manager.h"

#include "chrome/browser/notifications/sync_notifier/chrome_notifier_service.h"

#include "chrome/browser/notifications/sync_notifier/synced_notification.h"

@@ -114,8 +115,12 @@ std::string GetNotificationId(const SyncData& sync_data) {

// Stub out the NotificationUIManager for unit testing.

class StubNotificationUIManager : public NotificationUIManager {

public:

- StubNotificationUIManager() : notification_(GURL(), GURL(), string16(),

- string16(), NULL) {}

+ StubNotificationUIManager()

+ : notification_(GURL(),

+ GURL(),

+ string16(),

+ new MockNotificationDelegate("stub")) {}

virtual ~StubNotificationUIManager() {}

// Adds a notification to be displayed. Virtual for unit test override.