Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(236)

Issue 14631004: Fix OperationSystemVersion() on Android. (Closed)

Created:
7 years, 7 months ago by Zhenyao Mo
Modified:
7 years, 7 months ago
Reviewers:
brettw, no sievers
CC:
chromium-reviews, erikwright+watch_chromium.org, sail+watch_chromium.org
Visibility:
Public.

Description

Fix OperationSystemVersion() on Android. Right now it returns the underlying kernal version instead of the Android version. However, OperatingSystemVersionNumbers returns the Android version. Per discussion with Android folks, we agree the Android version should be returned. This CL copies what we do for Mac version. This piece of information could be very useful in defining driver bug workarounds in a finer grid on Android. BUG=225582 TEST=OperationSystemVersion() returns android version, see about:gpu R=brettw Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=198629

Patch Set 1 #

Patch Set 2 : #

Total comments: 2

Patch Set 3 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -1 line) Patch
M base/sys_info_android.cc View 1 2 2 chunks +7 lines, -0 lines 0 comments Download
M base/sys_info_posix.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 6 (0 generated)
Zhenyao Mo
Brett, Daniel, please take a look.
7 years, 7 months ago (2013-05-06 22:36:06 UTC) #1
brettw
lgtm https://codereview.chromium.org/14631004/diff/13001/base/sys_info_android.cc File base/sys_info_android.cc (right): https://codereview.chromium.org/14631004/diff/13001/base/sys_info_android.cc#newcode141 base/sys_info_android.cc:141: return base::StringPrintf("%d.%d.%d", major, minor, bugfix); Don't need "base::" ...
7 years, 7 months ago (2013-05-06 22:56:24 UTC) #2
Zhenyao Mo
https://codereview.chromium.org/14631004/diff/13001/base/sys_info_android.cc File base/sys_info_android.cc (right): https://codereview.chromium.org/14631004/diff/13001/base/sys_info_android.cc#newcode141 base/sys_info_android.cc:141: return base::StringPrintf("%d.%d.%d", major, minor, bugfix); On 2013/05/06 22:56:24, brettw ...
7 years, 7 months ago (2013-05-06 23:07:07 UTC) #3
no sievers
lgtm. thanks!
7 years, 7 months ago (2013-05-06 23:10:21 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/zmo@chromium.org/14631004/22001
7 years, 7 months ago (2013-05-06 23:11:28 UTC) #5
commit-bot: I haz the power
7 years, 7 months ago (2013-05-07 04:52:47 UTC) #6
Message was sent while issue was closed.
Change committed as 198629

Powered by Google App Engine
This is Rietveld 408576698