Issue 14629026: Fix an assertion failure in Range::textNodeSplit by Text::splitText.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 14629026: Fix an assertion failure in Range::textNodeSplit by Text::splitText. (Closed)

Created:
7 years, 7 months ago by tkent

Modified:
7 years, 7 months ago

Reviewers:
yosin_UTC9, eseidel

CC:
blink-reviews, dglazkov+blink, eae+blinkwatch, adamk+blink_chromium.org

Base URL:
svn://svn.chromium.org/blink/trunk

Visibility:
Public.

More Reviews

Description

Fix an assertion failure in Range::textNodeSplit by Text::splitText. Range::textNodeSplit is called in Text::splitText, and it assumes the next sibling node is still a Text node. A DOM mutation event handler can break this assumption. We had better postpone DOM mutation events dispatched in Node::insertBefore until exiting splitText to avoid inconsistent Range state. BUG=240163 TEST=automated. Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=150493

Patch Set 1 #

Created: 7 years, 7 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+37 lines, -0 lines)			Patch
A	LayoutTests/fast/dom/Range/split-text-in-range.html	View	1 chunk	+25 lines, -0 lines	0 comments	Download
A	LayoutTests/fast/dom/Range/split-text-in-range-expected.txt	View	1 chunk	+10 lines, -0 lines	0 comments	Download
M	Source/core/dom/Text.cpp	View	2 chunks	+2 lines, -0 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/tkent@chromium.org/14629026/1

7 years, 7 months ago (2013-05-16 06:00:47 UTC) #3

Message was sent while issue was closed.

Change committed as 150493

Expand Messages | Collapse Messages