Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(37)

Issue 14629026: Fix an assertion failure in Range::textNodeSplit by Text::splitText. (Closed)

Created:
7 years, 7 months ago by tkent
Modified:
7 years, 7 months ago
Reviewers:
yosin_UTC9, eseidel
CC:
blink-reviews, dglazkov+blink, eae+blinkwatch, adamk+blink_chromium.org
Visibility:
Public.

Description

Fix an assertion failure in Range::textNodeSplit by Text::splitText. Range::textNodeSplit is called in Text::splitText, and it assumes the next sibling node is still a Text node. A DOM mutation event handler can break this assumption. We had better postpone DOM mutation events dispatched in Node::insertBefore until exiting splitText to avoid inconsistent Range state. BUG=240163 TEST=automated. Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=150493

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+37 lines, -0 lines) Patch
A LayoutTests/fast/dom/Range/split-text-in-range.html View 1 chunk +25 lines, -0 lines 0 comments Download
A LayoutTests/fast/dom/Range/split-text-in-range-expected.txt View 1 chunk +10 lines, -0 lines 0 comments Download
M Source/core/dom/Text.cpp View 2 chunks +2 lines, -0 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
tkent
7 years, 7 months ago (2013-05-16 05:12:51 UTC) #1
yosin_UTC9
LGTM
7 years, 7 months ago (2013-05-16 05:39:35 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/tkent@chromium.org/14629026/1
7 years, 7 months ago (2013-05-16 06:00:47 UTC) #3
commit-bot: I haz the power
7 years, 7 months ago (2013-05-16 06:49:19 UTC) #4
Message was sent while issue was closed.
Change committed as 150493

Powered by Google App Engine
This is Rietveld 408576698