Issue 14629021: Shift additional_index by element_shift_size, not shift_size.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 14629021: Shift additional_index by element_shift_size, not shift_size. (Closed)

Created:
7 years, 7 months ago by Toon Verwaest

Modified:
7 years, 7 months ago

Reviewers:
Massi, Jakob Kummerow

CC:
v8-dev

Base URL:
https://v8.googlecode.com/svn/branches/bleeding_edge

Visibility:
Public.

Shift additional_index by element_shift_size, not shift_size. R=jkummerow@chromium.org Committed: https://code.google.com/p/v8/source/detail?r=14690

Created: 7 years, 7 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+3 lines, -2 lines)			Patch
	M	src/ia32/lithium-codegen-ia32.cc	View		2 chunks	+3 lines, -2 lines	0 comments	Download

Total messages: 3 (0 generated)

Jakob Kummerow

Drive-by LGTM. Good catch! Does this show up as a bug anywhere? In a small ...

7 years, 7 months ago (2013-05-15 11:02:36 UTC) #2

Toon Verwaest

7 years, 7 months ago (2013-05-15 14:04:50 UTC) #3

Message was sent while issue was closed.

Committed patchset #1 manually as r14690 (presubmit successful).