Adding 'git cl format' command for clang-format.

Adding 'git cl format' command for clang-format.

As per the discussion in
https://groups.google.com/a/chromium.org/forum/?fromgroups=#!topic/chromium-dev/Hl2QPNQ9E5o,
this CL adds a 'git cl format' command. Users may use it at their own
discretion. By default, it generates a diff against the local tracking
(upstream) branch and runs clang-format-diff on that diff.  When given the
'--full' flag, it instead identifies all .cc, .cpp, and .h files in the diff and
runs clang-format on the entirety of each of those files.

Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=198477

[agable, 2013-05-02 17:42:32]

maruel@: I haven't edited git_cl.py before, so please make sure this new command
is done right and is something you're willing to have in there.

gspencer, darin, torne, & cjhopman: This code is based on the code you were
tossing around at the end of the chromium-dev thread. Can you please download
the patch and make sure this works as expected for you?

[Greg Spencer (Chromium), 2013-05-02 18:20:11]

Thanks for adding this.

https://codereview.chromium.org/14629012/diff/1/git_cl.py
File git_cl.py (right):

https://codereview.chromium.org/14629012/diff/1/git_cl.py#newcode1928
git_cl.py:1928: parser.add_option('--full', action='store_true', default=False)
It might be nice to be able to specify specific files to do this to, where it
just formats the files you asked it to.

Seems like it should take a list of filenames as well, and intersect that list
with the diff output.  Probably the best way to do that is just append them
after a "--" to the diff command args.

[M-A Ruel, 2013-05-02 20:38:43]

https://codereview.chromium.org/14629012/diff/1/git_cl.py
File git_cl.py (right):

https://codereview.chromium.org/14629012/diff/1/git_cl.py#newcode1928
git_cl.py:1928: parser.add_option('--full', action='store_true', default=False)
On 2013/05/02 18:20:11, Greg Spencer (Chromium) wrote:
> It might be nice to be able to specify specific files to do this to, where it
> just formats the files you asked it to.

Then, this doesn't belong to git-cl. git-cl is not a one-stop place to put all
possible features.

> Seems like it should take a list of filenames as well, and intersect that list
> with the diff output.  Probably the best way to do that is just append them
> after a "--" to the diff command args.

https://codereview.chromium.org/14629012/diff/1/git_cl.py#newcode1933
git_cl.py:1933: diff = RunGit(['diff', '--name-only']).split()
I'd suggest you to list the valid extensions at the top of this file, then:

cmd.append('--')
cmd.extend('*.' + i for i in EXTENSIONS)

Then you don't have to filter afterward.

https://codereview.chromium.org/14629012/diff/1/git_cl.py#newcode1942
git_cl.py:1942: diff = RunGit(['diff', '-U0', '@{u}'])
Same with filtering on the file names

[agable, 2013-05-02 20:50:17]

https://codereview.chromium.org/14629012/diff/1/git_cl.py
File git_cl.py (right):

https://codereview.chromium.org/14629012/diff/1/git_cl.py#newcode1928
git_cl.py:1928: parser.add_option('--full', action='store_true', default=False)
On 2013/05/02 20:38:43, Marc-Antoine Ruel wrote:
> On 2013/05/02 18:20:11, Greg Spencer (Chromium) wrote:
> > It might be nice to be able to specify specific files to do this to, where
it
> > just formats the files you asked it to.
> 
> Then, this doesn't belong to git-cl. git-cl is not a one-stop place to put all
> possible features.
> 
> > Seems like it should take a list of filenames as well, and intersect that
list
> > with the diff output.  Probably the best way to do that is just append them
> > after a "--" to the diff command args.

Agreed with maruel@ here. If we want an easy command to run clang-format on
arbitrary files, that can go elsewhere. This is intended to run just on what
you've changed in your feature branch.

https://codereview.chromium.org/14629012/diff/1/git_cl.py#newcode1933
git_cl.py:1933: diff = RunGit(['diff', '--name-only']).split()
On 2013/05/02 20:38:43, Marc-Antoine Ruel wrote:
> I'd suggest you to list the valid extensions at the top of this file, then:
> 
> cmd.append('--')
> cmd.extend('*.' + i for i in EXTENSIONS)
> 
> Then you don't have to filter afterward.

I put CLANG_EXTS at the top of this function, not the file, because nothing else
in the file is clang-specific. Other than that, done, since not wasting the time
to diff non-clang files is a good idea.

[M-A Ruel, 2013-05-03 01:55:56]

lgtm with nits

https://codereview.chromium.org/14629012/diff/5001/git_cl.py
File git_cl.py (right):

https://codereview.chromium.org/14629012/diff/5001/git_cl.py#newcode1941
git_cl.py:1941: RunCommand(cmd)
RunCommand(['clang-format', '-i'] + files)

https://codereview.chromium.org/14629012/diff/5001/git_cl.py#newcode1943
git_cl.py:1943: cfd_path = os.path.join('/usr', 'lib', 'clang-format',
It looks like it fits one line.

[agable, 2013-05-06 17:41:31]

https://codereview.chromium.org/14629012/diff/5001/git_cl.py
File git_cl.py (right):

https://codereview.chromium.org/14629012/diff/5001/git_cl.py#newcode1941
git_cl.py:1941: RunCommand(cmd)
On 2013/05/03 01:55:56, Marc-Antoine Ruel wrote:
> RunCommand(['clang-format', '-i'] + files)

Done.

https://codereview.chromium.org/14629012/diff/5001/git_cl.py#newcode1943
git_cl.py:1943: cfd_path = os.path.join('/usr', 'lib', 'clang-format',
On 2013/05/03 01:55:56, Marc-Antoine Ruel wrote:
> It looks like it fits one line.

Nope, it's 82 chars.

[commit-bot: I haz the power, 2013-05-06 17:41:43]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/agable@chromium.org/14629012/10001

[commit-bot: I haz the power, 2013-05-06 17:43:10]

Change committed as 198477

[Jiang, 2013-05-06 19:27:31]

https://codereview.chromium.org/14629012/diff/10001/git_cl.py
File git_cl.py (right):

https://codereview.chromium.org/14629012/diff/10001/git_cl.py#newcode1957
git_cl.py:1957: cmd = [sys.executable,
'/usr/lib/clang-format/clang-format-diff.py',
Why don't you use cfd_path here?