Adding fast path for generalizing maps.

Adding fast path for generalizing maps.

Committed: https://code.google.com/p/v8/source/detail?r=14523

[Toon Verwaest, 2013-05-02 13:27:38]

PTAL

[danno, 2013-05-02 14:26:41]

https://codereview.chromium.org/14629005/diff/5/src/objects.cc
File src/objects.cc (right):

https://codereview.chromium.org/14629005/diff/5/src/objects.cc#newcode7365
src/objects.cc:7365: other_details.type() != CONSTANT_FUNCTION) {
What about when other_details is a FIELD and details is a CONSTANT_FUNCTION?

https://codereview.chromium.org/14629005/diff/5/src/objects.cc#newcode7372
src/objects.cc:7372: } else if
(!other_details.representation().fits(details.representation())) {
So, merge doesn't seem to be commutative? Shouldn't your comments be more of the
phrasing "merge of 'this' _into_ 'other'"?

https://codereview.chromium.org/14629005/diff/5/src/property-details.h
File src/property-details.h (right):

https://codereview.chromium.org/14629005/diff/5/src/property-details.h#newcod...
src/property-details.h:112: bool fits(const Representation& other) const {
how about "fits_in"? Easier to read e.g. (if this->fits_into(that))

[Toon Verwaest, 2013-05-02 15:15:57]

Addressed comments

https://chromiumcodereview.appspot.com/14629005/diff/5/src/objects.cc
File src/objects.cc (right):

https://chromiumcodereview.appspot.com/14629005/diff/5/src/objects.cc#newcode...
src/objects.cc:7365: other_details.type() != CONSTANT_FUNCTION) {
In that case |this| is not a valid updated version of |other|, and we'll have to
Merge again.

On 2013/05/02 14:26:41, danno wrote:
> What about when other_details is a FIELD and details is a CONSTANT_FUNCTION?

https://chromiumcodereview.appspot.com/14629005/diff/5/src/property-details.h
File src/property-details.h (right):

https://chromiumcodereview.appspot.com/14629005/diff/5/src/property-details.h...
src/property-details.h:112: bool fits(const Representation& other) const {
On 2013/05/02 14:26:41, danno wrote:
> how about "fits_in"? Easier to read e.g. (if this->fits_into(that))

Done.

[danno, 2013-05-02 15:27:59]

lgtm

[Toon Verwaest, 2013-05-02 15:41:09]

Committed patchset #2 manually as r14523 (presubmit successful).