Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2792)

Unified Diff: chrome/browser/ui/views/validation_message_bubble_delegate.cc

Issue 14627004: Re-implement form validation message UI with native widgets (Views) (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 7 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/ui/views/validation_message_bubble_delegate.cc
diff --git a/chrome/browser/ui/views/validation_message_bubble_delegate.cc b/chrome/browser/ui/views/validation_message_bubble_delegate.cc
new file mode 100644
index 0000000000000000000000000000000000000000..a1b65f4d5c9a525a3df78b13b0d1a0673ac3eec8
--- /dev/null
+++ b/chrome/browser/ui/views/validation_message_bubble_delegate.cc
@@ -0,0 +1,98 @@
+// Copyright (c) 2013 The Chromium Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+#include "chrome/browser/ui/views/validation_message_bubble_delegate.h"
+
+#include "grit/theme_resources.h"
+#include "ui/base/resource/resource_bundle.h"
+#include "ui/views/controls/image_view.h"
+#include "ui/views/controls/label.h"
+#include "ui/views/widget/widget.h"
+
+// static
+const int ValidationMessageBubbleDelegate::kWindowMinWidth = 64;
+// static
+const int ValidationMessageBubbleDelegate::kWindowMaxWidth = 256;
+static const int kPadding = 0;
Nico 2013/05/02 16:52:30 fyi: const has implicit internal linkage, so there
+static const int kIconTextMargin = 8;
+static const int kTextVerticalMargin = 4;
+
+ValidationMessageBubbleDelegate::ValidationMessageBubbleDelegate(
+ const gfx::Rect& anchor_in_screen,
+ const string16& main_text,
+ const string16& sub_text,
+ Observer* observer)
+ : observer_(observer), width_(0), height_(0) {
+ set_use_focusless(true);
+ set_arrow(views::BubbleBorder::TOP_LEFT);
+ set_anchor_rect(anchor_in_screen);
+
+ ResourceBundle& bundle = ResourceBundle::GetSharedInstance();
+ views::ImageView* icon = new views::ImageView();
+ icon->SetImage(*bundle.GetImageSkiaNamed(IDR_INPUT_ALERT));
+ gfx::Size size = icon->GetPreferredSize();
+ icon->SetBounds(kPadding, kPadding, size.width(), size.height());
+ AddChildView(icon);
+
+ views::Label* label = new views::Label(main_text);
+ label->SetHorizontalAlignment(gfx::ALIGN_LEFT);
+ label->SetFont(bundle.GetFont(ResourceBundle::MediumFont));
+ label->set_directionality_mode(views::Label::AUTO_DETECT_DIRECTIONALITY);
+ int text_start_x = kPadding + size.width() + kIconTextMargin;
+ int min_available = kWindowMinWidth - text_start_x - kPadding;
+ int max_available = kWindowMaxWidth - text_start_x - kPadding;
+ int label_width = label->GetPreferredSize().width();
+ label->SetMultiLine(true);
+ AddChildView(label);
+
+ views::Label* sub_label = NULL;
+ if (!sub_text.empty()) {
+ sub_label = new views::Label(sub_text);
+ sub_label->SetHorizontalAlignment(gfx::ALIGN_LEFT);
+ sub_label->set_directionality_mode(
+ views::Label::AUTO_DETECT_DIRECTIONALITY);
+ label_width = std::max(label_width, sub_label->GetPreferredSize().width());
+ sub_label->SetMultiLine(true);
+ AddChildView(sub_label);
+ }
+
+ if (label_width < min_available)
+ label_width = min_available;
+ else if (label_width > max_available)
+ label_width = max_available;
+ label->SetBounds(text_start_x, kPadding,
+ label_width, label->GetHeightForWidth(label_width));
+ int content_bottom = kPadding + label->height();
+
+ if (sub_label) {
+ sub_label->SetBounds(text_start_x,
+ content_bottom + kTextVerticalMargin,
+ label_width,
+ sub_label->GetHeightForWidth(label_width));
+ content_bottom += kTextVerticalMargin + sub_label->height();
+ }
+
+ width_ = text_start_x + label_width + kPadding;
+ height_ = content_bottom + kPadding;
+}
+
+ValidationMessageBubbleDelegate::~ValidationMessageBubbleDelegate() {}
+
+void ValidationMessageBubbleDelegate::Hide() {
+ GetWidget()->Hide();
+ observer_ = NULL;
+}
+
+gfx::Size ValidationMessageBubbleDelegate::GetPreferredSize() {
+ return gfx::Size(width_, height_);
+}
+
+void ValidationMessageBubbleDelegate::DeleteDelegate() {
+ delete this;
+}
+
+void ValidationMessageBubbleDelegate::WindowClosing() {
+ if (observer_ != NULL)
+ observer_->WindowClosing();
+}

Powered by Google App Engine
This is Rietveld 408576698