Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1130)

Unified Diff: net/http/http_network_transaction_spdy2_unittest.cc

Issue 14625012: net: Return LoadTiming information in the case of a cache hit (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src/
Patch Set: Small fix Created 7 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: net/http/http_network_transaction_spdy2_unittest.cc
===================================================================
--- net/http/http_network_transaction_spdy2_unittest.cc (revision 199488)
+++ net/http/http_network_transaction_spdy2_unittest.cc (working copy)
@@ -146,11 +146,11 @@
EXPECT_FALSE(load_timing_info.send_start.is_null());
EXPECT_LE(load_timing_info.send_start, load_timing_info.send_end);
- EXPECT_LE(load_timing_info.send_end, load_timing_info.receive_headers_end);
- // Set by URLRequest, at a higher level.
+ // Set at a higher level.
EXPECT_TRUE(load_timing_info.request_start_time.is_null());
EXPECT_TRUE(load_timing_info.request_start.is_null());
+ EXPECT_TRUE(load_timing_info.receive_headers_end.is_null());
}
// Tests LoadTimingInfo in the case a new socket is used and no PAC script is
@@ -164,16 +164,16 @@
EXPECT_TRUE(load_timing_info.proxy_resolve_end.is_null());
net::ExpectConnectTimingHasTimes(load_timing_info.connect_timing,
- connect_timing_flags);
+ connect_timing_flags);
EXPECT_LE(load_timing_info.connect_timing.connect_end,
load_timing_info.send_start);
EXPECT_LE(load_timing_info.send_start, load_timing_info.send_end);
- EXPECT_LE(load_timing_info.send_end, load_timing_info.receive_headers_end);
- // Set by URLRequest, at a higher level.
+ // Set at a higher level.
EXPECT_TRUE(load_timing_info.request_start_time.is_null());
EXPECT_TRUE(load_timing_info.request_start.is_null());
+ EXPECT_TRUE(load_timing_info.receive_headers_end.is_null());
}
// Tests LoadTimingInfo in the case a socket is reused and a PAC script is
@@ -190,11 +190,11 @@
EXPECT_LE(load_timing_info.proxy_resolve_end,
load_timing_info.send_start);
EXPECT_LE(load_timing_info.send_start, load_timing_info.send_end);
- EXPECT_LE(load_timing_info.send_end, load_timing_info.receive_headers_end);
- // Set by URLRequest, at a higher level.
+ // Set at a higher level.
EXPECT_TRUE(load_timing_info.request_start_time.is_null());
EXPECT_TRUE(load_timing_info.request_start.is_null());
+ EXPECT_TRUE(load_timing_info.receive_headers_end.is_null());
}
// Tests LoadTimingInfo in the case a new socket is used and a PAC script is
@@ -215,11 +215,11 @@
load_timing_info.send_start);
EXPECT_LE(load_timing_info.send_start, load_timing_info.send_end);
- EXPECT_LE(load_timing_info.send_end, load_timing_info.receive_headers_end);
- // Set by URLRequest, at a higher level.
+ // Set at a higher level.
EXPECT_TRUE(load_timing_info.request_start_time.is_null());
EXPECT_TRUE(load_timing_info.request_start.is_null());
+ EXPECT_TRUE(load_timing_info.receive_headers_end.is_null());
}
} // namespace

Powered by Google App Engine
This is Rietveld 408576698