net: Return LoadTiming information in the case of a cache hit

net/http/http_cache_transaction.h

Index: net/http/http_cache_transaction.h
===================================================================
--- net/http/http_cache_transaction.h	(revision 199488)
+++ net/http/http_cache_transaction.h	(working copy)
@@ -385,6 +385,10 @@
   void RunDelayedLoop(base::TimeTicks delay_start_time,
                       base::TimeDelta intended_delay, int result);
 
+  // Updates |last_network_trans_load_timing_| from |network_trans_|, which must
+  // be non-NULL.  Only called before deleting the old transaction.

[gavinp, 2013/05/10 20:23:03]

I think "old network transaction" would make things clearer for me, as there's
three sorts of transactions I can think about here.

[mmenke, 2013/05/10 20:44:00]

Done.  I agree that "old" is clearer.

+  void CacheLoadTimingInformation();

[gavinp, 2013/05/10 20:23:03]

In that vein, using "Cache" here to mean "make a copy of and keep" instead of
"the http disk cache" is... Confusing.

I propose:

CopyLoadTimingInformationFromNetworkTransaction().

Or even:

ResetNetworkTransaction();

(and move network_trans_.reset() into the method).

[mmenke, 2013/05/10 20:44:00]

Switched to ResetNetworkTransaction, since we always call them together.  For
some reason, was thinking there was a cleanup function where updating the cached
copy wasn't needed.

+
   State next_state_;
   const HttpRequestInfo* request_;
   RequestPriority priority_;
@@ -447,6 +451,11 @@
   int sensitivity_analysis_percent_increase_;
 
   HttpTransactionDelegate* transaction_delegate_;
+
+  // Load timing information for the last network request, if any.  Set in the
+  // 304 and 206 response cases, as the network transaction may be destroyed
+  // before the caller requests load timing information.
+  scoped_ptr<LoadTimingInfo> last_network_trans_load_timing_;
 };
 
 }  // namespace net