Issue 14623025: Revert "Revert "Replace ScriptWrappable pointer masking with back-pointer check in DOMDataStore.""

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 14623025: Revert "Revert "Replace ScriptWrappable pointer masking with back-pointer check in DOMDataStore."" (Closed)

Created:
7 years, 7 months ago by danakj

Modified:
7 years, 7 months ago

Reviewers:
Tom Sepez

CC:
blink-reviews, jsbell+bindings_chromium.org, eae+blinkwatch, abarth-chromium, adamk+blink_chromium.org, haraken, Nate Chapin

Base URL:
svn://svn.chromium.org/blink/trunk

Visibility:
Public.

More Reviews

Description

Revert "Revert "Replace ScriptWrappable pointer masking with back-pointer check in DOMDataStore."" This reverts commit e50f45d7f690b278b380cff418de2253137dd808. The bots are busted, reverts won't give us much info if they aren't going to fix the bots. BUG=239522 TBR=tsepez@chromium.org Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=150095

Patch Set 1 #

Created: 7 years, 7 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+26 lines, -31 lines)			Patch
	M	Source/bindings/v8/DOMDataStore.h	View		2 chunks	+12 lines, -4 lines	0 comments	Download
	M	Source/bindings/v8/ScriptWrappable.h	View		6 chunks	+14 lines, -27 lines	0 comments	Download

Messages

Total messages: 1 (0 generated)

Expand Messages | Collapse Messages

danakj

7 years, 7 months ago (2013-05-10 16:07:51 UTC) #1

Message was sent while issue was closed.

Committed patchset #1 manually as r150095 (presubmit successful).

Expand Messages | Collapse Messages