Issue 14622024: Define containers for more SandboxedProcessServices.

Issue 14622024: Define containers for more SandboxedProcessServices. (Closed)

Created:
7 years, 7 months ago by palmer

Modified:
7 years, 7 months ago

Reviewers:
joth, Yaron, bulach

CC:
chromium-reviews, joi+watch-content_chromium.org, darin-cc_chromium.org, jam

Base URL:
https://chromium.googlesource.com/chromium/src.git@master

Visibility:
Public.

More Reviews

Description

Define containers for more SandboxedProcessServices. More available, isolated renderers gives us a greater margin of safety. BUG= Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=200970

Patch Set 1 #

Patch Set 2 : Let ChildProcessLauncher know there are now 10, not 6. #

Created: 7 years, 7 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+5 lines, -5 lines)			Patch
A +	content/public/android/java/src/org/chromium/content/app/SandboxedProcessService6.java	View		1 chunk	+1 line, -1 line	0 comments	Download
A +	content/public/android/java/src/org/chromium/content/app/SandboxedProcessService7.java	View		1 chunk	+1 line, -1 line	0 comments	Download
A +	content/public/android/java/src/org/chromium/content/app/SandboxedProcessService8.java	View		1 chunk	+1 line, -1 line	0 comments	Download
A +	content/public/android/java/src/org/chromium/content/app/SandboxedProcessService9.java	View		1 chunk	+1 line, -1 line	0 comments	Download
M	content/public/android/java/src/org/chromium/content/browser/ChildProcessLauncher.java	View	1	1 chunk	+1 line, -1 line	0 comments	Download

Messages

Total messages: 9 (0 generated)

Expand Messages | Collapse Messages

Yaron

I don't think this is sufficient by itself. Dont' you also need to update ChildProcessLauncher ...

7 years, 7 months ago (2013-05-16 20:08:16 UTC) #2

bulach

lgtm since it's a 0 cost experiment for now, but pretty please, do not actually ...

7 years, 7 months ago (2013-05-17 10:26:20 UTC) #3

palmer

> lgtm since it's a 0 cost experiment for now, but pretty please, do not ...

7 years, 7 months ago (2013-05-17 18:51:52 UTC) #5

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/palmer@chromium.org/14622024/4001

7 years, 7 months ago (2013-05-17 18:52:07 UTC) #6

commit-bot: I haz the power

Retried try job too often on win_rel for step(s) content_browsertests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=win_rel&number=150490

7 years, 7 months ago (2013-05-17 22:13:44 UTC) #7

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/palmer@chromium.org/14622024/4001

7 years, 7 months ago (2013-05-17 22:15:08 UTC) #8

Message was sent while issue was closed.

Change committed as 200970

Expand Messages | Collapse Messages