Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(629)

Issue 14619018: As discussed in blink-dev mailing list remove getPropertyShorthand and isImplicit from the Web expo… (Closed)

Created:
7 years, 7 months ago by darktears
Modified:
7 years, 7 months ago
CC:
blink-reviews, caseq+blink_chromium.org, loislo+blink_chromium.org, eustas+blink_chromium.org, alph+blink_chromium.org, eae+blinkwatch, yurys+blink_chromium.org, lushnikov+blink_chromium.org, vsevik+blink_chromium.org, pfeldman+blink_chromium.org, apavlov+blink_chromium.org, aandrey+blink_chromium.org
Visibility:
Public.

Description

As discussed in blink-dev mailing list remove getPropertyShorthand and isImplicit from the Web exposed APIs. They were added because of the Inspector back in 2005 when it was using JS. It does not remove the actual C++ implementation as this one is still used by the inspector. I've updated few layout tests to remove the usage of these functions. Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=150051

Patch Set 1 #

Messages

Total messages: 5 (0 generated)
darktears
7 years, 7 months ago (2013-05-09 20:14:09 UTC) #1
eseidel
lgtm To be clear: no other browser implements these, correct?
7 years, 7 months ago (2013-05-09 20:16:41 UTC) #2
darktears
On 2013/05/09 20:16:41, Eric Seidel wrote: > lgtm > > To be clear: no other ...
7 years, 7 months ago (2013-05-09 20:52:59 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/alexis.menard@intel.com/14619018/1
7 years, 7 months ago (2013-05-09 20:53:22 UTC) #4
commit-bot: I haz the power
7 years, 7 months ago (2013-05-09 20:56:07 UTC) #5
Message was sent while issue was closed.
Change committed as 150051

Powered by Google App Engine
This is Rietveld 408576698