[Autofill] Add geolocation data to Risk fingerprint.

[Autofill] Add geolocation data to Risk fingerprint.

BUG=166596
TEST=out/Debug/browser_tests --gtest_filter=AutofillRiskFingerprintTest.*

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=200804

[Evan Stade, 2013-04-30 17:34:34]

lgtm

[commit-bot: I haz the power, 2013-04-30 21:08:03]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/isherman@chromium.org/14619006/1

[commit-bot: I haz the power, 2013-04-30 23:20:54]

Retried try job too often on linux_rel for step(s) browser_tests
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=linux_rel&...

[Ilya Sherman, 2013-05-01 00:21:24]

+jknotten for content/browser/geolocation OWNERS approval.

[Ilya Sherman, 2013-05-01 19:04:39]

+bulach for content/browser/geolocation OWNERS approval.

Is jknotten still working on Chrome?  I wasn't able to find him in the internal
directory...

[bulach, 2013-05-02 10:48:46]

+joth

sorry for the confusion Ilya, unfortunately jknotten is no longer in our team
(just sent a patch to remove him from the OWNERS)..

as for this patch: there's very little context here, but since geolocation is
privacy sensitive, let's be extra careful. a few questions:

- where/how is this autofill fingerprint used? is it stored, transmitted, etc..,
?
- has the user granted permission to use their geolocation at that point? for
other parts of the system, we require showing an infobar at least once to
indicate that geolocation is going to be used.

[Ilya Sherman, 2013-05-02 22:16:29]

On 2013/05/02 10:48:46, bulach wrote:
> +joth
> 
> sorry for the confusion Ilya, unfortunately jknotten is no longer in our team
> (just sent a patch to remove him from the OWNERS)..
> 
> as for this patch: there's very little context here, but since geolocation is
> privacy sensitive, let's be extra careful. a few questions:
> 
> - where/how is this autofill fingerprint used? is it stored, transmitted,
etc..,
> ?

It is transmitted to the Google Wallet Risk engine, which is a fraud detection
engine.  It is only transmitted for users using the (still-under-development)
"interactive Autofill" feature, and only when users give consent to using the
service.

> - has the user granted permission to use their geolocation at that point? for
> other parts of the system, we require showing an infobar at least once to
> indicate that geolocation is going to be used.

Yes.  The interactive Autofill dialog includes the following notice (wording
might change slightly to be even clearer): "To prevent fraud, information Google
Chrome collects about my computer (including its location) will be shared with
Google Wallet."

I've cc'ed you and joth on the email thread discussing this in *much* more
detail :)

[Ilya Sherman, 2013-05-09 07:45:41]

Evan, please take another look.  There were non-trivial changes introduced after
jam@'s refactoring.

bulach@ and joth@, note that I'm not calling UserDidOptIntoLocationServices() in
this CL -- that'll be in a separate CL.

[Evan Stade, 2013-05-16 21:14:49]

lgtm

[Ilya Sherman, 2013-05-17 04:46:25]

Committing this CL with use_high_accuracy=false for now, since that is the last
remaining point of contention (being discussed off the code review, via email). 
Will send out a tiny follow-up CL to enable high accuracy mode if we conclude
that it's needed.

[commit-bot: I haz the power, 2013-05-17 04:46:42]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/isherman@chromium.org/14619006/43001

[commit-bot: I haz the power, 2013-05-17 09:13:32]

Retried try job too often on win_rel for step(s) nacl_integration
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=win_rel&nu...

[commit-bot: I haz the power, 2013-05-17 09:24:14]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/isherman@chromium.org/14619006/43001

[commit-bot: I haz the power, 2013-05-17 13:41:31]

Change committed as 200804