Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(822)

Issue 14617016: Forward log calls to Chrome's log handler and not create a specific log file for libpeerconnection. (Closed)

Created:
7 years, 7 months ago by tommi (sloooow) - chröme
Modified:
7 years, 7 months ago
CC:
chromium-reviews
Visibility:
Public.

Description

Forward log calls to Chrome's log handler and not create a specific log file for libpeerconnection. BUG=239048 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=199549

Patch Set 1 #

Patch Set 2 : rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+10 lines, -6 lines) Patch
M third_party/libjingle/overrides/init_webrtc.h View 2 chunks +2 lines, -0 lines 0 comments Download
M third_party/libjingle/overrides/init_webrtc.cc View 2 chunks +1 line, -1 line 0 comments Download
M third_party/libjingle/overrides/initialize_module.cc View 2 chunks +7 lines, -5 lines 0 comments Download

Messages

Total messages: 7 (0 generated)
tommi (sloooow) - chröme
7 years, 7 months ago (2013-05-10 15:03:43 UTC) #1
Mallinath (Gone from Chromium)
lgtm.
7 years, 7 months ago (2013-05-10 16:42:25 UTC) #2
commit-bot: I haz the power
No LGTM from a valid reviewer yet. Only full committers are accepted. Even if an ...
7 years, 7 months ago (2013-05-10 16:52:40 UTC) #3
tommi (sloooow) - chröme
Ronghua: I need an owner that's also a full committer :) Looks like Mallinath is ...
7 years, 7 months ago (2013-05-10 16:54:08 UTC) #4
Ronghua Wu (Left Chromium)
I believe I'm also the owner. :) LGTM
7 years, 7 months ago (2013-05-10 16:56:33 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/tommi@chromium.org/14617016/4001
7 years, 7 months ago (2013-05-10 16:58:14 UTC) #6
commit-bot: I haz the power
7 years, 7 months ago (2013-05-10 21:36:22 UTC) #7
Message was sent while issue was closed.
Change committed as 199549

Powered by Google App Engine
This is Rietveld 408576698