Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(226)

Issue 14612004: Remove CURSOR_VISIBILITY, it's always off (Closed)

Created:
7 years, 7 months ago by esprehn
Modified:
7 years, 7 months ago
Reviewers:
ojan, eseidel
CC:
blink-reviews, apavlov+blink_chromium.org, jchaffraix+rendering, darktears, tdanderson
Visibility:
Public.

Description

Remove CURSOR_VISIBILITY, it's always off This feature was added as -webkit-cursor-visibility: auto-hide which lets an app control auto hiding the mouse cursor, specifically for full screen mode and <video> but is not standard and we never turned it on. As implemented I don't think we want this, it's hard coded at 3 seconds and applies to all video elements in full screened subtrees which seems like surprising behavior if the video is a tiny part of the full screen content. Moreover it seems that https://code.google.com/p/chromium/issues/detail?id=102508 says we don't want this feature and would prefer authors to use script to show and hide the cursor. I think we may want something declarative eventually, but we can add the code back when we make that decision. Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=149507

Patch Set 1 #

Patch Set 2 : Upload again #

Total comments: 1

Patch Set 3 : Fix UseCounter #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -150 lines) Patch
M Source/core/css/CSSComputedStyleDeclaration.cpp View 1 2 2 chunks +0 lines, -7 lines 0 comments Download
M Source/core/css/CSSParser.cpp View 1 2 1 chunk +0 lines, -7 lines 0 comments Download
M Source/core/css/CSSPrimitiveValueMappings.h View 1 chunk +0 lines, -28 lines 0 comments Download
M Source/core/css/CSSProperty.cpp View 1 chunk +0 lines, -3 lines 0 comments Download
M Source/core/css/CSSPropertyNames.in View 1 chunk +0 lines, -3 lines 0 comments Download
M Source/core/css/CSSValueKeywords.in View 1 chunk +0 lines, -4 lines 0 comments Download
M Source/core/css/StyleBuilder.cpp View 1 chunk +0 lines, -3 lines 0 comments Download
M Source/core/css/StyleResolver.cpp View 1 2 1 chunk +0 lines, -3 lines 0 comments Download
M Source/core/css/fullscreen.css View 1 chunk +0 lines, -4 lines 0 comments Download
M Source/core/page/EventHandler.h View 2 chunks +0 lines, -10 lines 0 comments Download
M Source/core/page/EventHandler.cpp View 1 2 4 chunks +0 lines, -50 lines 0 comments Download
M Source/core/page/UseCounter.h View 1 2 1 chunk +1 line, -1 line 0 comments Download
M Source/core/rendering/style/RenderStyle.h View 6 chunks +0 lines, -20 lines 0 comments Download
M Source/core/rendering/style/RenderStyleConstants.h View 1 chunk +0 lines, -7 lines 0 comments Download

Messages

Total messages: 7 (0 generated)
esprehn
7 years, 7 months ago (2013-05-01 01:13:56 UTC) #1
ojan
lgtm Makes me a little sad that we don't auto-hide the cursor. But, we have ...
7 years, 7 months ago (2013-05-01 01:31:13 UTC) #2
jamesr
I think Terry's been working on cursor auto-hiding stuff. I'm not sure this code is ...
7 years, 7 months ago (2013-05-01 02:01:40 UTC) #3
esprehn
On 2013/05/01 02:01:40, jamesr wrote: > I think Terry's been working on cursor auto-hiding stuff. ...
7 years, 7 months ago (2013-05-01 03:54:27 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/esprehn@chromium.org/14612004/2001
7 years, 7 months ago (2013-05-01 03:54:42 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/esprehn@chromium.org/14612004/7001
7 years, 7 months ago (2013-05-01 03:59:26 UTC) #6
commit-bot: I haz the power
7 years, 7 months ago (2013-05-01 05:21:00 UTC) #7
Message was sent while issue was closed.
Change committed as 149507

Powered by Google App Engine
This is Rietveld 408576698