Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(602)

Unified Diff: src/stub-cache.cc

Issue 14611006: Cleanup IC heuristics. (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge
Patch Set: Addressed nit Created 7 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « src/objects.cc ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: src/stub-cache.cc
diff --git a/src/stub-cache.cc b/src/stub-cache.cc
index 63748779b11c59a75f08aa77eb778ecc3f367277..8de81016e2b49ac63df12ab1d0f66bd531eb2c72 100644
--- a/src/stub-cache.cc
+++ b/src/stub-cache.cc
@@ -431,15 +431,7 @@ Handle<Code> StubCache::ComputeStoreTransition(Handle<Name> name,
StrictModeFlag strict_mode) {
Handle<Code> stub = FindIC(
name, receiver, Code::STORE_IC, Code::MAP_TRANSITION, strict_mode);
- if (!stub.is_null()) {
- MapHandleList embedded_maps;
- stub->FindAllMaps(&embedded_maps);
- for (int i = 0; i < embedded_maps.length(); i++) {
- if (embedded_maps.at(i).is_identical_to(transition)) {
- return stub;
- }
- }
- }
+ if (!stub.is_null()) return stub;
StoreStubCompiler compiler(isolate_, strict_mode);
Handle<Code> code =
@@ -589,15 +581,7 @@ Handle<Code> StubCache::ComputeKeyedStoreTransition(
StrictModeFlag strict_mode) {
Handle<Code> stub = FindIC(
name, receiver, Code::KEYED_STORE_IC, Code::MAP_TRANSITION, strict_mode);
- if (!stub.is_null()) {
- MapHandleList embedded_maps;
- stub->FindAllMaps(&embedded_maps);
- for (int i = 0; i < embedded_maps.length(); i++) {
- if (embedded_maps.at(i).is_identical_to(transition)) {
- return stub;
- }
- }
- }
+ if (!stub.is_null()) return stub;
KeyedStoreStubCompiler compiler(isolate(), strict_mode, STANDARD_STORE);
Handle<Code> code =
« no previous file with comments | « src/objects.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698