Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(97)

Issue 14607015: Fix includes in SkLayerDrawLooper.h. It was previously not possible to (Closed)

Created:
7 years, 7 months ago by jbroman
Modified:
7 years, 6 months ago
CC:
skia-review_googlegroups.com
Visibility:
Public.

Description

Fix includes in SkLayerDrawLooper.h. It was previously not possible to include this header unless SkPoint and SkPaint were previously defined. BUG= Committed: http://code.google.com/p/skia/source/detail?r=9130

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -3 lines) Patch
M include/effects/SkLayerDrawLooper.h View 1 chunk +2 lines, -2 lines 1 comment Download
M src/effects/SkLayerDrawLooper.cpp View 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 7 (0 generated)
jbroman
I was trying to move a usage of SkLayerDrawLooper in Blink, and I had to ...
7 years, 7 months ago (2013-05-14 18:41:06 UTC) #1
reed1
lgtm
7 years, 7 months ago (2013-05-14 19:32:04 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://skia-tree-status.appspot.com/cq/jbroman@chromium.org/14607015/1
7 years, 7 months ago (2013-05-14 19:43:40 UTC) #3
commit-bot: I haz the power
Change committed as 9130
7 years, 7 months ago (2013-05-14 20:11:25 UTC) #4
scroggo
https://chromiumcodereview.appspot.com/14607015/diff/1/include/effects/SkLayerDrawLooper.h File include/effects/SkLayerDrawLooper.h (right): https://chromiumcodereview.appspot.com/14607015/diff/1/include/effects/SkLayerDrawLooper.h#newcode13 include/effects/SkLayerDrawLooper.h:13: #include "SkPoint.h" It appears to me that #include "SkPoint.h" ...
7 years, 7 months ago (2013-05-14 21:06:05 UTC) #5
jbroman
On 2013/05/14 21:06:05, scroggo wrote: > https://chromiumcodereview.appspot.com/14607015/diff/1/include/effects/SkLayerDrawLooper.h > File include/effects/SkLayerDrawLooper.h (right): > > https://chromiumcodereview.appspot.com/14607015/diff/1/include/effects/SkLayerDrawLooper.h#newcode13 > ...
7 years, 7 months ago (2013-05-14 21:15:23 UTC) #6
scroggo
7 years, 7 months ago (2013-05-14 21:17:36 UTC) #7
Message was sent while issue was closed.
On 2013/05/14 21:15:23, jbroman wrote:
> On 2013/05/14 21:06:05, scroggo wrote:
> >
>
https://chromiumcodereview.appspot.com/14607015/diff/1/include/effects/SkLaye...
> > File include/effects/SkLayerDrawLooper.h (right):
> > 
> >
>
https://chromiumcodereview.appspot.com/14607015/diff/1/include/effects/SkLaye...
> > include/effects/SkLayerDrawLooper.h:13: #include "SkPoint.h"
> > It appears to me that #include "SkPoint.h" can be removed entirely. I do not
> see
> > SkPoint referenced anywhere in this file or in the cpp file.
> 
> SkVector (a typedef for SkPoint) is defined in SkPoint.h.

Touche.

Powered by Google App Engine
This is Rietveld 408576698