scripts/common/annotator.py - Issue 14602020: Add an AOSP builder recipe. - Code Review

Chromium Code Reviews

chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out

(577)

My Issues | Starred Open | Closed | All

Unified Diff: scripts/common/annotator.py

Issue 14602020: Add an AOSP builder recipe. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/tools/build

Patch Set: rebase on top of CL 15270004 Created 7 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

« no previous file with comments | « no previous file | scripts/slave/android/generate_whitelist_deps_step.py » ('j') | scripts/slave/android/generate_whitelist_deps_step.py » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: scripts/common/annotator.py

diff --git a/scripts/common/annotator.py b/scripts/common/annotator.py

index bca5f3f1700cd66b18d203d72b7e6692fddedab4..eb0c86b4feb3cab4153006b6a85317848f502192 100755

--- a/scripts/common/annotator.py

+++ b/scripts/common/annotator.py

@@ -381,7 +381,8 @@ def _run_step(stream, build_failure,

ret = chromium_utils.RunCommand(command=map(str, cmd),

cwd=cwd,

env=_merge_envs(os.environ, env),

- filter_obj=filter_obj)

+ filter_obj=filter_obj,

+ pipes=step_dict.get('pipes'))

iannucci 2013/05/20 19:41:38 I think this is no longer necessary?

mkosiba (inactive) 2013/05/21 10:56:07 Done.

if ret != 0:

print 'step returned non-zero exit code: %d' % ret

print 'step was: %s' % json.dumps(step_dict)

« no previous file with comments | « no previous file | scripts/slave/android/generate_whitelist_deps_step.py » ('j') | scripts/slave/android/generate_whitelist_deps_step.py » ('J')

Powered by Google App Engine

This is Rietveld 408576698